feat: add support for typed constants in AlphabeticallyOrderedConstan… #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.0.x #142 +/- ##
==========================================
+ Coverage 95.25% 95.45% +0.19%
==========================================
Files 3 3
Lines 232 264 +32
==========================================
+ Hits 221 252 +31
- Misses 11 12 +1 ☔ View full report in Codecov by Sentry. |
simPod
requested changes
Mar 7, 2024
Contributor
simPod
left a comment
simPod
left a comment
There was a problem hiding this comment.
Compare with #141 PHPCSStandards/PHP_CodeSniffer#332
Maybe it could be simplified?
davidxkurka
force-pushed
the
dk/ordered-constants-data-type-support
branch
from
79579b7 to
49d6355
Compare
simPod
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tsSniff