PART 2: Generate events using jsonschema2pojo and mustache template #60

rjalander · 2023-10-03T10:51:01Z

Continuation of the PR #58 to generate all other events using the mustache template,
Generating all events from schema repo

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com>

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com> Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> update CDEventsGenerator file Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> update CDEventsGenerator file Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> Update phase for CDEventsGenerator main class Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> adding missing file to repo Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> Update src/main/java/dev/cdevents/CDEventsGenerator.java Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com> Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> Update src/main/java/dev/cdevents/CDEventsGenerator.java Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com> Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> update with review comments and some linter issues Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> fix linter issues Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> updating linter.yml Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> fix linter issues with MagicNumber Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> fix linter issues with MagicNumber Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> lint exclude list in array path Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> update FILTER_REGEX_EXCLUDE pattern Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> update MaginNumners with constants Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> ignoreFieldDeclaration for MagicNumber check-style Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> cleanup existing/manual events to keep only gererated events Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> Refacoring the code to use maven submodules for generator and sdk Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> fix minor lint issue Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech> updating release files as per comment Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

…sdk_v0_1_2

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

rjalander · 2023-10-17T08:45:22Z

@afrittoli can you please review theses changes when you get some time. Thank you.

afrittoli · 2023-11-27T14:14:03Z

generator/pom.xml

@@ -84,10 +85,12 @@
                        </goals>
                        <configuration>
                            <sourcePaths>
-                                <sourcePath>${sdk.project.dir}/src/main/resources/schema/artifact-packaged-event.json
-                                </sourcePath>
+                                <sourcePath>${parent.project.dir}/spec/schemas/artifactpackaged.json</sourcePath>


The only slight issue I see with this approach is that new events will have to be added manually to this config.
It actually may be a positive thing to have a static configuration, but perhaps we should have some kind of check in place that verifies that a class has been generated for every schema available.

Ok, I will create a separate issue to verify the number of generated files from schemas with unit testing.

afrittoli · 2023-11-27T14:15:34Z

generator/pom.xml

                            </sourcePaths>
+                            <outputDirectory>${sdk.project.dir}/src/main/java</outputDirectory>


This is a bit long to properly review manually, did you generate it with a script, or do you have a script to verify its correctness?

This file is created manually, but I can add a test to verify the number of generated files from schemas

afrittoli · 2023-11-27T14:18:14Z

spec

Nice, pointing to v0.1.2 for now! +1

afrittoli · 2023-11-27T14:19:27Z

generator/src/main/java/dev/cdevents/generator/CDEventsGenerator.java

+            } else {
+                log.error("No schema files found in the specified directory {}", folder.getAbsolutePath());
            }
+        } else {
+            log.error("No schema directory found in the specified directory {}", folder.getAbsolutePath());


For automation purposes, it would be nice if the tool accumulated the various errors and failed at the end, rather than only logging errors.

afrittoli

Thanks @rjalander - I left a couple of comments, but nothing blocking - perhaps we can iterate on this in another PR.
I did not review the pom.xml in details, let me know if you need to me to do that or if you have some script to verify it.

Could you squash the commits into a few ones (or one) before merging please?

cdevents-bot · 2024-01-11T15:26:06Z

🎉 This issue has been resolved in v0.3.0 (Release Notes)

Jalander Ramagiri and others added 30 commits June 26, 2023 13:54

Changes to generate class file using template

8b200ae

update CDEventsGenerator file

f40e395

update CDEventsGenerator file

12fa8c2

Update phase for CDEventsGenerator main class

a2673d1

adding missing file to repo

1aa585b

Update src/main/java/dev/cdevents/CDEventsGenerator.java

a57c616

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com>

Update src/main/java/dev/cdevents/CDEventsGenerator.java

a9e7c90

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com>

update with review comments and some linter issues

2a66889

fix linter issues

487705a

updating linter.yml

30f3e7d

fix linter issues with MagicNumber

678e197

fix linter issues with MagicNumber

a8c7831

lint exclude list in array path

90f2e2a

update FILTER_REGEX_EXCLUDE pattern

20cd637

update MaginNumners with constants

759d00c

ignoreFieldDeclaration for MagicNumber check-style

a5bb503

cleanup existing/manual events to keep only gererated events

e865d59

Generate models and events from spec/schema repo

3369ae9

Changes to generate class file using template

9865d62

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

update CDEventsGenerator file

886070a

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

update CDEventsGenerator file

3653b32

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Update phase for CDEventsGenerator main class

7366ba2

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

adding missing file to repo

fcb0514

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Update src/main/java/dev/cdevents/CDEventsGenerator.java

8dc440a

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com> Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Update src/main/java/dev/cdevents/CDEventsGenerator.java

8bf6783

Co-authored-by: Lapenta Francesco Davide <37077655+lapentad@users.noreply.github.com> Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

update with review comments and some linter issues

8715628

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

fix linter issues

8e837e6

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

updating linter.yml

fb70e74

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

fix linter issues with MagicNumber

a594c13

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

fix linter issues with MagicNumber

04151e7

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Jalander Ramagiri and others added 12 commits July 13, 2023 11:16

updating release files as per comment

ea383aa

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Merge branch 'gen_sdk_v0_1_2' of github.com:Nordix/sdk-java into gen_…

52992b5

…sdk_v0_1_2

removing plugin definition from sdk/pom

9c10633

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

removing test dependencies

8b4ec23

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Merge branch 'main' into gen_sdk_v0_1_2

6571579

Update parent pom artifactId

4080307

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

Update sdk and generator pom artifact version

7aa2e7e

Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>

merge from gen_sdk_v0_1_2 branch for the latest changes

c12ab5a

adding test file to sdk

65de572

removing old event files

29feacf

merge from master branch with events generator changes

fca78fb

rjalander requested review from afrittoli, andrew-est and adamkenihan October 3, 2023 10:53

Jalander Ramagiri added 2 commits October 6, 2023 11:11

fix linter issue

7eda387

adding submodule in actions to checkout

a9631b5

rjalander added the hacktoberfest label Oct 19, 2023

rjalander self-assigned this Oct 19, 2023

afrittoli reviewed Nov 27, 2023

View reviewed changes

spec

Copy link

Contributor

afrittoli Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pointing to v0.1.2 for now! +1

rjalander reacted with thumbs up emoji

afrittoli reviewed Nov 27, 2023

View reviewed changes

afrittoli approved these changes Nov 27, 2023

View reviewed changes

rjalander merged commit 2e914b3 into cdevents:main Nov 30, 2023

rjalander mentioned this pull request Nov 30, 2023

Verify SDK generator has been generated event classes for every schema available #61

Closed

rjalander mentioned this pull request Dec 14, 2023

CDEvents generator using jsonschema #46

Closed

cdevents-bot added the released Issue has been released label Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PART 2: Generate events using jsonschema2pojo and mustache template #60

PART 2: Generate events using jsonschema2pojo and mustache template #60

Uh oh!

rjalander commented Oct 3, 2023

Uh oh!

rjalander commented Oct 17, 2023

Uh oh!

afrittoli Nov 27, 2023

Uh oh!

rjalander Nov 30, 2023

Uh oh!

afrittoli Nov 27, 2023

Uh oh!

rjalander Nov 30, 2023

Uh oh!

afrittoli Nov 27, 2023

Uh oh!

afrittoli Nov 27, 2023

Uh oh!

afrittoli left a comment •

edited

Loading

Uh oh!

cdevents-bot commented Jan 11, 2024

Uh oh!

Uh oh!

		</sourcePaths>
		<outputDirectory>${sdk.project.dir}/src/main/java</outputDirectory>

PART 2: Generate events using jsonschema2pojo and mustache template #60

PART 2: Generate events using jsonschema2pojo and mustache template #60

Uh oh!

Conversation

rjalander commented Oct 3, 2023

Uh oh!

rjalander commented Oct 17, 2023

Uh oh!

afrittoli Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

rjalander Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

afrittoli Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

rjalander Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

afrittoli Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

afrittoli Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

afrittoli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cdevents-bot commented Jan 11, 2024

Uh oh!

Uh oh!

afrittoli left a comment •

edited

Loading