Validate artifactId with PacakgeURL format #47
Conversation
| @@ -5,7 +5,7 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
| <groupId>dev.cdevents</groupId> | |||
| <artifactId>cdevents-sdk-java</artifactId> | |||
| <version>0.1.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Updated this version to 0.1.2 as currently the SDK follows v0.1.2 spec
There was a problem hiding this comment.
Thanks!
As I understand it, this will then be updated to 0.1.2 (without the -SNAPSHOT) when we make a release, and for now 0.1.2-SNAPSHOT is fine.
@aalmiray is that correct?
There was a problem hiding this comment.
Yes, that is correct. The convention is to keep -SNAPSHOT while doing development. This tag must go away during release.
| <dependency> | ||
| <groupId>com.github.package-url</groupId> | ||
| <artifactId>packageurl-java</artifactId> | ||
| <version>${packageurl.version}</version> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
This is MIT, so it's fine.
@aalmiray @rjalander is there a way to automate license checks for dependencies in pom.xml?
There was a problem hiding this comment.
There's a Maven plugin we could use. Let me find out how to configure it.
|
🎉 This issue has been resolved in |
Adding packageurl-java dependency and validate artifactId with packageurl-java