Skip to content

Doc: Update readme with the example to create PipelineRunFinished CDEvent #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2023

Conversation

rjalander
Copy link
Contributor

No description provided.

DEVELOPMENT.md Outdated

1. [`git`](https://help.github.com/articles/set-up-git/): For source control

1. [`java`](https://www.oracle.com/java/technologies/downloads/): The language this SDK is built in.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be sequential? I see in other parts of the guide you use all 1. and was curious if thats a standard you have seen or if this will be more easily read by end users? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. is used in markdown to mark a numbered bullet list. The markdown rendering engine replaces the ones with a numbered list.
The advantage of using 1. everywhere is that one doesn't have to renumber all items when adding something new in the middle

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is a neat feature, I'm a novice user of markdown (using the basic design capabilities to create readme) and will start using this now!

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates

@afrittoli
Copy link
Contributor

@aalmiray does this look ok to merge to you now?

@aalmiray
Copy link
Contributor

aalmiray commented May 2, 2023

The groupId was updated in pom.xml but left unchanged in the doc.

@afrittoli afrittoli merged commit bffc18f into cdevents:main May 2, 2023
@cdevents-bot cdevents-bot added the released Issue has been released label Jul 24, 2023
@cdevents-bot
Copy link
Collaborator

🎉 This issue has been resolved in v0.1.2 (Release Notes)

@cdevents-bot cdevents-bot added this to the v0.1.2 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants