-
Notifications
You must be signed in to change notification settings - Fork 6
Doc: Update readme with the example to create PipelineRunFinished CDEvent #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DEVELOPMENT.md
Outdated
|
||
1. [`git`](https://help.github.com/articles/set-up-git/): For source control | ||
|
||
1. [`java`](https://www.oracle.com/java/technologies/downloads/): The language this SDK is built in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be sequential? I see in other parts of the guide you use all 1.
and was curious if thats a standard you have seen or if this will be more easily read by end users? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.
is used in markdown to mark a numbered bullet list. The markdown rendering engine replaces the ones with a numbered list.
The advantage of using 1.
everywhere is that one doesn't have to renumber all items when adding something new in the middle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is a neat feature, I'm a novice user of markdown (using the basic design capabilities to create readme) and will start using this now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates
@aalmiray does this look ok to merge to you now? |
The |
🎉 This issue has been resolved in |
No description provided.