Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules aren't checked out for git dependencies in extra-deps #44

Closed
isomorpheme opened this issue Feb 15, 2024 · 0 comments · Fixed by #53
Closed

Submodules aren't checked out for git dependencies in extra-deps #44

isomorpheme opened this issue Feb 15, 2024 · 0 comments · Fixed by #53

Comments

@isomorpheme
Copy link

Similar story to #38 - it's this fetchgit call again:

rawSrc = builtins.fetchGit {
url = haskPkgLock.git;
name = srcName;
rev = haskPkgLock.commit;
allRefs = true;
};

An example where this breaks things is libjwt-typed, where the cbits subdir has a submodule with header files etc. that are needed.

I've checked that the issue is fixed when I add submodules = true to fetchgit, and I can open a PR for that, but I've noticed that evaluation can slow down if there's repos involved that have large submodules (e.g. tensorflow), so I'm not sure if that's the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant