Skip to content

Commit ca44dc0

Browse files
committed
WIP 2
1 parent 53d7ba9 commit ca44dc0

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

mypy/expandtype.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,14 @@ def visit_type_var(self, t: TypeVarType) -> Type:
240240
def visit_param_spec(self, t: ParamSpecType) -> Type:
241241
# Set prefix to something empty, so we don't duplicate it below.
242242
repl = self.variables.get(t.id, t.copy_modified(prefix=Parameters([], [], [])))
243+
if isinstance(repl, ParamSpecType):
244+
if (tvar_id := repl.id) in self.recursive_tvar_guard:
245+
return self.recursive_tvar_guard[tvar_id] or repl
246+
self.recursive_tvar_guard[tvar_id] = None
247+
repl = repl.accept(self)
248+
if isinstance(repl, ParamSpecType):
249+
repl.default = repl.default.accept(self)
250+
self.recursive_tvar_guard[tvar_id] = repl
243251
if isinstance(repl, ParamSpecType):
244252
return repl.copy_modified(
245253
flavor=t.flavor,

test-data/unit/check-typevar-defaults.test

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,32 @@ def func_d3(
512512
m = ClassD3[int, float]()
513513
reveal_type(m) # N: Revealed type is "__main__.ClassD3[builtins.int, builtins.float]"
514514

515+
[case testTypeVarDefaultsClassRecursive2]
516+
# flags: --disallow-any-generics
517+
from typing import Generic, ParamSpec
518+
519+
P1 = ParamSpec("P1", default=[int, str])
520+
P2 = ParamSpec("P2", default=P1)
521+
P3 = ParamSpec("P3")
522+
523+
class ClassE1(Generic[P1, P2]): ...
524+
525+
def func_e1(
526+
a: ClassE1,
527+
b: ClassE1[[float]],
528+
c: ClassE1[[float], [str]],
529+
) -> None:
530+
reveal_type(a) # N: Revealed type is "__main__.ClassE1[[builtins.int, builtins.str], [builtins.int, builtins.str]]"
531+
reveal_type(b) # N: Revealed type is "__main__.ClassE1[[builtins.float], [builtins.float]]"
532+
reveal_type(c) # N: Revealed type is "__main__.ClassE1[[builtins.float], [builtins.str]]"
533+
534+
k = ClassE1()
535+
# reveal_type(k) # Revealed type is "__main__.ClassE1[[builtins.int, builtins.str], [builtins.int, builtins.str]]" # TODO
536+
l = ClassE1[[float]]()
537+
reveal_type(l) # N: Revealed type is "__main__.ClassE1[[builtins.float], [builtins.float]]"
538+
m = ClassE1[[float], [str]]()
539+
reveal_type(m) # N: Revealed type is "__main__.ClassE1[[builtins.float], [builtins.str]]"
540+
515541
[case testTypeVarDefaultsClassRecursiveMultipleFiles]
516542
# flags: --disallow-any-generics
517543
from typing import Generic, TypeVar

0 commit comments

Comments
 (0)