Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pre-selection of any Eve character is a security risk #30

Open
DaneelTrevize opened this issue Apr 27, 2018 · 0 comments
Open

[Bug] Pre-selection of any Eve character is a security risk #30

DaneelTrevize opened this issue Apr 27, 2018 · 0 comments

Comments

@DaneelTrevize
Copy link

DaneelTrevize commented Apr 27, 2018

Bug

Following ESI issue #303 / SSO issue #10 discussion on tweetfleet Slack, it was agreed that any pre-selection of a character during SSO is a mechanism by which users may become complacent as to which character they're revealing they control on a given account.

CCP SnowedIn [10:00 PM]
+1 for no preselect

Reproduction Steps

Have several characters on 1 Eve account.
Be redirected to SSO for any 3rd party app. The app will know which characterID this is intended to be for.
Note that during the SSO screen, the first character is pre-selected by CCP, no confirmation of this choice is needed.
Confirm any scope set presented, ignoring the character choice, and complete the SSO.
If this is not the intended character to be authenticated, the referring app now knows the differing expected and recieved characterIDs are both on the same single account.

Expected Behaviour

Any choice of character should have to be manually confirmed by the user, to avoid abusable bias in the reduction of 3 Eve characters to 1 OAuth response per account SSO referral.

@DaneelTrevize DaneelTrevize changed the title Pre-selection of any Eve character is a security risk [Bug] Pre-selection of any Eve character is a security risk Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant