-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gene bed and gene info #12
Comments
Hi again, I've been investigating this issue and I see that when a gene_name does not exist in the gene_bed file, something does wrong with the gene order algorithm which assigns the fusion category/type. Do you all have any suggestions on how to find the issue? |
Hey there, Sorry for going dark for so long. This completely fell off my radar. From the main MetaFusion/scripts/MetaFusion.sh Lines 96 to 102 in 81df512
MetaFusion/scripts/MetaFusion.sh Lines 113 to 116 in 81df512
That said, it's possible that the error is coming from downstream if there's a problem when reading the transformed data. Perhaps there's an uncaught case that's producing a default value. Do you happen to know which output file is the first one affected? That might help us pinpoint which function/script needs to be looked at. Cheers, |
The part that I saw having the effect is during reann_cff_fusion.py. MetaFusion/scripts/pygeneann_MetaFusion.py Lines 874 to 888 in 81df512
Particularly: Also I just noticed its an if -> if statement for score1, but elsif for score 2 |
Ah, I remember asking one of the authors about Line 877. Unfortunately, I never got a satisfactory response about that. The equality comparison between
My guess is that there were multiple contributors and someone noticed the
You'd be correct in that regard. If all the scores are 0 and |
Upon further analysis, I found that the issue I was facing was actually a dual issue:
A flag for when these things occurs to tell the analyst that the fusion may not be the correct annotation in these cases would be very helpful. |
Additionally I think |
I think that should be possible if you edit the code. Since that section of code is a method of CffFusion, you could probably create a new attribute for that flag. However, you'll also need to edit downstream to check for that flag. Alternatively, you could edit the gene name to include a unique suffix. |
EDIT:
I think a better way to phrase this:
When a gene_name/symbol from NCBI in the gene info does not belong to the gene bed file (ensembl version outdated so synonyms changed/areas remapped/discovered,etc), a warning is spit out:
MetaFusion/scripts/pygeneann_MetaFusion.py
Lines 1792 to 1795 in 81df512
What happens to the gene in this instance? We are seeing a lot of NoHeadGene/truncated annotations. Gene order will probably not change from the caller in these cases... (since score seems to be dependent on the annotation in the gene bed file) Is anything else effected?
The text was updated successfully, but these errors were encountered: