deps: update cpu_features to 545b2e84ec68f4364be1e89309a1404575689226

Author: mscdex

deps/cpu_features/CMakeLists.txt

@@ -23,13 +23,11 @@ endif(NOT CMAKE_BUILD_TYPE)
 # As a consequence it is discouraged to use cpu_features as a shared library because different compilers may interpret the code in different ways.
 # Prefer static linking from source whenever possible.
 option(BUILD_SHARED_LIBS "Build library as shared." OFF)
-# PIC
-option(BUILD_PIC "Build with Position Independant Code." OFF) # Default is off at least for GCC
 
 # Force PIC on unix when building shared libs
 # see: https://en.wikipedia.org/wiki/Position-independent_code
 if(BUILD_SHARED_LIBS AND UNIX)
-  set(BUILD_PIC ON)
+  option(CMAKE_POSITION_INDEPENDENT_CODE "Build with Position Independant Code." ON)
 endif()
 
 include(CheckIncludeFile)
@@ -101,7 +99,6 @@ add_library(utils OBJECT
   ${PROJECT_SOURCE_DIR}/src/stack_line_reader.c
   ${PROJECT_SOURCE_DIR}/src/string_view.c
 )
-set_property(TARGET utils PROPERTY POSITION_INDEPENDENT_CODE ${BUILD_PIC})
 setup_include_and_definitions(utils)
 
 #
@@ -122,7 +119,6 @@ if(UNIX)
   if(HAVE_STRONG_GETAUXVAL)
     target_compile_definitions(unix_based_hardware_detection PRIVATE HAVE_STRONG_GETAUXVAL)
   endif()
-  set_property(TARGET unix_based_hardware_detection PROPERTY POSITION_INDEPENDENT_CODE ${BUILD_PIC})
 endif()
 
 #
@@ -139,7 +135,6 @@ add_library(cpu_features ${CPU_FEATURES_HDRS} ${CPU_FEATURES_SRCS})
 set_target_properties(cpu_features PROPERTIES PUBLIC_HEADER "${CPU_FEATURES_HDRS}")
 setup_include_and_definitions(cpu_features)
 target_link_libraries(cpu_features PUBLIC ${CMAKE_DL_LIBS})
-set_property(TARGET cpu_features PROPERTY POSITION_INDEPENDENT_CODE ${BUILD_PIC})
 target_include_directories(cpu_features
   PUBLIC $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/cpu_features>
 )

deps/cpu_features/cpu_features.gyp

@@ -77,7 +77,7 @@
         ],
         'defines': [
           # Manually-tracked git revision
-          'CPU_FEATURES_VERSION_REV=cf589a28444eadf01fc94fd7afaf517be2cf9774',
+          'CPU_FEATURES_VERSION_REV=545b2e84ec68f4364be1e89309a1404575689226',
         ],
       },
     },

deps/cpu_features/src/cpuinfo_x86.c

@@ -110,6 +110,7 @@
 #else
 #error "Unsupported OS"
 #endif  // CPU_FEATURES_OS
+
 #include "internal/string_view.h"
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -1698,11 +1699,10 @@ void FillX86BrandString(char brand_string[49]) {
       SafeCpuId(max_cpuid_leaf_ext, 0x80000003),
       SafeCpuId(max_cpuid_leaf_ext, 0x80000004),
   };
-  const size_t leaves_size = sizeof(leaves);
 #if __STDC_VERSION__ >= 201112L
   _Static_assert(sizeof(leaves) == 48, "Leaves must be packed");
 #endif
-  CpuFeatures_StringView_CopyString(view((const char*)leaves, leaves_size),
+  CpuFeatures_StringView_CopyString(view((const char*)leaves, sizeof(leaves)),
                                     brand_string, 49);
 }