(ISSUE-87) Honor status code in the sendContent method

Author: chtyim

src/main/java/io/cdap/http/internal/BasicHttpResponder.java

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2017-2019 Cask Data, Inc.
+ * Copyright © 2017-2020 Cask Data, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not
  * use this file except in compliance with the License. You may obtain a copy of
@@ -26,7 +26,6 @@
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelFuture;
 import io.netty.channel.ChannelFutureListener;
-import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.ChannelPipeline;
 import io.netty.channel.DefaultFileRegion;
@@ -174,7 +173,7 @@ public void sendContent(HttpResponseStatus status, final BodyProducer bodyProduc
       return;
     }
 
-    HttpResponse response = new DefaultHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.OK);
+    HttpResponse response = new DefaultHttpResponse(HttpVersion.HTTP_1_1, status);
     addContentTypeIfMissing(response.headers().add(headers), OCTET_STREAM_TYPE);
 
     if (contentLength < 0L) {

src/test/java/io/cdap/http/HttpServerTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2014-2019 Cask Data, Inc.
+ * Copyright © 2014-2020 Cask Data, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not
  * use this file except in compliance with the License. You may obtain a copy of
@@ -843,6 +843,14 @@ public void testBodyProducer() throws Exception {
     Assert.assertFalse(failureFile.isFile());
   }
 
+  @Test
+  public void testBodyProducerStatus() throws Exception {
+    for (int status : Arrays.asList(200, 400, 404, 500)) {
+      HttpURLConnection urlConn = request("/test/v1/produceBodyWithStatus?status=" + status, HttpMethod.GET);
+      Assert.assertEquals(status, urlConn.getResponseCode());
+    }
+  }
+
   @Test
   public void testCompressResponse() throws Exception {
     HttpURLConnection urlConn = request("/test/v1/compressResponse?message=Testing+message", HttpMethod.GET);

src/test/java/io/cdap/http/TestHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2014-2019 Cask Data, Inc.
+ * Copyright © 2014-2020 Cask Data, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not
  * use this file except in compliance with the License. You may obtain a copy of
@@ -462,6 +462,29 @@ public void handleError(@Nullable Throwable cause) {
     }, EmptyHttpHeaders.INSTANCE);
   }
 
+  @Path("/produceBodyWithStatus")
+  @GET
+  public void produceBodyWithStatus(HttpRequest request, HttpResponder responder,
+                                    @QueryParam("status") @DefaultValue("200") final int status) {
+
+    responder.sendContent(HttpResponseStatus.valueOf(status), new BodyProducer() {
+      @Override
+      public ByteBuf nextChunk() {
+        return Unpooled.EMPTY_BUFFER;
+      }
+
+      @Override
+      public void finished() {
+        // no-op
+      }
+
+      @Override
+      public void handleError(@Nullable Throwable cause) {
+        // no-op
+      }
+    }, EmptyHttpHeaders.INSTANCE);
+  }
+
   @Path("/uexception")
   @GET
   public void testException(HttpRequest request, HttpResponder responder) {