Address comments

Author: chtyim

src/main/java/io/cdap/http/NettyHttpService.java

@@ -17,8 +17,8 @@
 package io.cdap.http;
 
 import io.cdap.http.internal.BasicHandlerContext;
-import io.cdap.http.internal.ForwardingEventExecutor;
 import io.cdap.http.internal.ForwardingEventExecutorGroup;
+import io.cdap.http.internal.ForwardingOrderedEventExecutor;
 import io.cdap.http.internal.HttpDispatcher;
 import io.cdap.http.internal.HttpResourceHandler;
 import io.cdap.http.internal.NonStickyEventExecutorGroup;
@@ -43,6 +43,7 @@
 import io.netty.util.concurrent.EventExecutorGroup;
 import io.netty.util.concurrent.Future;
 import io.netty.util.concurrent.ImmediateEventExecutor;
+import io.netty.util.concurrent.OrderedEventExecutor;
 import io.netty.util.concurrent.UnorderedThreadPoolEventExecutor;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -344,7 +345,12 @@ public void remove() {
       }
 
       private EventExecutor wrapEventExecutor(EventExecutor executor) {
-        return new ForwardingEventExecutor(executor) {
+        if (!(executor instanceof OrderedEventExecutor)) {
+          // This should never happen since we use the NonStickyEventExecutorGroup above.
+          throw new IllegalStateException("The executor is not an OrderedEventExecutor: " + executor.getClass());
+        }
+
+        return new ForwardingOrderedEventExecutor((OrderedEventExecutor) executor) {
 
           @Override
           public EventExecutorGroup parent() {

src/main/java/io/cdap/http/internal/ForwardingEventExecutor.java renamed to src/main/java/io/cdap/http/internal/ForwardingOrderedEventExecutor.java

@@ -19,6 +19,7 @@
 import io.netty.util.concurrent.EventExecutor;
 import io.netty.util.concurrent.EventExecutorGroup;
 import io.netty.util.concurrent.Future;
+import io.netty.util.concurrent.OrderedEventExecutor;
 import io.netty.util.concurrent.ProgressivePromise;
 import io.netty.util.concurrent.Promise;
 import io.netty.util.concurrent.ScheduledFuture;
@@ -32,13 +33,13 @@
 import java.util.concurrent.TimeoutException;
 
 /**
- * A {@link EventExecutor} that forwards all methods to another {@link EventExecutor}.
+ * An {@link OrderedEventExecutor} that forwards all methods to another {@link OrderedEventExecutor}.
  */
-public class ForwardingEventExecutor implements EventExecutor {
+public class ForwardingOrderedEventExecutor implements OrderedEventExecutor {
 
-  private final EventExecutor delegate;
+  private final OrderedEventExecutor delegate;
 
-  public ForwardingEventExecutor(EventExecutor delegate) {
+  public ForwardingOrderedEventExecutor(OrderedEventExecutor delegate) {
     this.delegate = delegate;
   }