-
-
Notifications
You must be signed in to change notification settings - Fork 256
Open
Labels
Description
Issue
Spinning this off of #1930 per discussion with @RodriSanchez1:
When a new user to the site visits the root path (/), the WelcomeScreen component is rendered.
#1930 aims to make the AuthScreen (/login-signup) Close (X) button send the user to / if they do not have any browsing history on the app. In this case, closing the AuthScreen via this button renders WelcomeScreen because isFirstVisit && !isLogged is true, when sending the user to /board/root makes more sense:
cboard/src/components/App/App.component.js
Lines 84 to 90 in 1a7e0a9
| <Route | |
| exact | |
| path="/" | |
| component={ | |
| isFirstVisit && !isLogged ? WelcomeScreen : BoardContainer | |
| } | |
| /> |
Steps to reproduce from AuthScreen:
- Visit
/login-signup - Run localStorage.removeItem('persist:root') from console
- Reload page
- Click X button in top left
Expected Behavior
User is redirected to the root board, similarly to if selecting "Skip for now" from WelcomeScreen.
Actual Behavior
User is shown WelcomeScreen, which is redundant.