Skip to content

First time visitor closing AuthScreen renders WelcomeScreen #1949

@zkarmi

Description

@zkarmi

Issue

Spinning this off of #1930 per discussion with @RodriSanchez1:

When a new user to the site visits the root path (/), the WelcomeScreen component is rendered.
#1930 aims to make the AuthScreen (/login-signup) Close (X) button send the user to / if they do not have any browsing history on the app. In this case, closing the AuthScreen via this button renders WelcomeScreen because isFirstVisit && !isLogged is true, when sending the user to /board/root makes more sense:

<Route
exact
path="/"
component={
isFirstVisit && !isLogged ? WelcomeScreen : BoardContainer
}
/>

Steps to reproduce from AuthScreen:

  1. Visit /login-signup
  2. Run localStorage.removeItem('persist:root') from console
  3. Reload page
  4. Click X button in top left

Expected Behavior

User is redirected to the root board, similarly to if selecting "Skip for now" from WelcomeScreen.

Actual Behavior

User is shown WelcomeScreen, which is redundant.

cboard-firsttimevisitor-close-authscreen.mov

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions