Skip to content

Commit

Permalink
Clarify that set noparent should be rarely used
Browse files Browse the repository at this point in the history
R=brettw@chromium.org

Change-Id: I049857e9eb094d60e153074b361dab7146a13623
Reviewed-on: https://chromium-review.googlesource.com/596968
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491425}
  • Loading branch information
jeisinger authored and Commit Bot committed Aug 2, 2017
1 parent a71ef16 commit ea8f92d
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions docs/code_reviews.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,10 @@ A `*` indicates that all committers are owners:
```
The text `set noparent` will stop owner propagation from parent directories.
This is used for specialized code. In this example, only the two listed people
are owners:
This should be rarely used. If you want to use `set noparent` except for IPC
related files, please first reach out to chrome-eng-review@google.com.
In this example, only the two listed people are owners:
```
set noparent
a@chromium.org
Expand Down

0 comments on commit ea8f92d

Please sign in to comment.