Skip to content

Commit

Permalink
Make Page Action popup bubble anchor its arrow on the left for RTL la…
Browse files Browse the repository at this point in the history
…nguages.

BUG=68030
TEST=See bug


Review URL: http://codereview.chromium.org/6119002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70752 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
finnur@chromium.org committed Jan 7, 2011
1 parent cfa4336 commit e8f98fa
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

Expand Down Expand Up @@ -83,13 +83,16 @@ void PageActionImageView::ExecuteAction(int button,
View::ConvertPointToScreen(this, &origin);
screen_bounds.set_origin(origin);

BubbleBorder::ArrowLocation arrow_location = base::i18n::IsRTL() ?
BubbleBorder::TOP_LEFT : BubbleBorder::TOP_RIGHT;

popup_ = ExtensionPopup::Show(
page_action_->GetPopupUrl(current_tab_id_),
browser,
browser->profile(),
browser->window()->GetNativeHandle(),
screen_bounds,
BubbleBorder::TOP_RIGHT,
arrow_location,
true, // Activate the popup window.
inspect_with_devtools,
ExtensionPopup::BUBBLE_CHROME,
Expand Down

0 comments on commit e8f98fa

Please sign in to comment.