Skip to content

Commit

Permalink
sign-in: Allow no-SAML-password to finish if caller does not care
Browse files Browse the repository at this point in the history
BUG=493265

Review URL: https://codereview.chromium.org/1164623002

Cr-Commit-Position: refs/heads/master@{#332042}
  • Loading branch information
xiyuan authored and Commit bot committed May 29, 2015
1 parent 95462a7 commit e6fc554
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions chrome/browser/resources/gaia_auth_host/authenticator.js
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,13 @@ cr.define('cr.login', function() {
} else if (this.samlHandler_.scrapedPasswordCount == 0) {
if (this.noPasswordCallback) {
this.noPasswordCallback(this.email_);
} else {
console.error('Authenticator: No password scraped for SAML.');
return;
}
return;

// Fall through to finish the auth flow even if this.needPassword
// is true. This is because the flag is used as an intention to get
// password when it is available but not a mandatory requirement.
console.warning('Authenticator: No password scraped for SAML.');
} else if (this.needPassword) {
if (this.confirmPasswordCallback) {
// Confirm scraped password. The flow follows in
Expand Down

0 comments on commit e6fc554

Please sign in to comment.