Add out-of-line copy ctors for complex classes. (new in win_clang)

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=dcheng@chromium.org, thakis@chromium.org
TBR=jochen@chromium.org, sievers@chromium.org, mcasas@chromium.org, alekseys@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/1886923002

Cr-Commit-Position: refs/heads/master@{#387193}

base/win/shortcut.cc

@@ -46,6 +46,9 @@ ShortcutProperties::ShortcutProperties()
     : icon_index(-1), dual_mode(false), options(0U) {
 }
 
+ShortcutProperties::ShortcutProperties(const ShortcutProperties& other) =
+    default;
+
 ShortcutProperties::~ShortcutProperties() {
 }
 

base/win/shortcut.h

@@ -51,6 +51,7 @@ struct BASE_EXPORT ShortcutProperties {
   };
 
   ShortcutProperties();
+  ShortcutProperties(const ShortcutProperties& other);
   ~ShortcutProperties();
 
   void set_target(const FilePath& target_in) {

chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc

@@ -359,6 +359,9 @@ MTPDeviceDelegateImplWin::PendingTaskInfo::PendingTaskInfo(
       reply(reply) {
 }
 
+MTPDeviceDelegateImplWin::PendingTaskInfo::PendingTaskInfo(
+    const PendingTaskInfo& other) = default;
+
 MTPDeviceDelegateImplWin::PendingTaskInfo::~PendingTaskInfo() {
 }
 

chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h

@@ -77,6 +77,7 @@ class MTPDeviceDelegateImplWin : public MTPDeviceAsyncDelegate {
     PendingTaskInfo(const tracked_objects::Location& location,
                     const base::Callback<base::File::Error(void)>& task,
                     const base::Callback<void(base::File::Error)>& reply);
+    PendingTaskInfo(const PendingTaskInfo& other);
     ~PendingTaskInfo();
 
     const tracked_objects::Location location;

chrome/browser/media_galleries/win/snapshot_file_details.cc

@@ -24,6 +24,9 @@ SnapshotRequestInfo::SnapshotRequestInfo(
       error_callback(error_callback) {
 }
 
+SnapshotRequestInfo::SnapshotRequestInfo(const SnapshotRequestInfo& other) =
+    default;
+
 SnapshotRequestInfo::~SnapshotRequestInfo() {
 }
 
@@ -38,6 +41,9 @@ SnapshotFileDetails::SnapshotFileDetails(
       bytes_written_(0) {
 }
 
+SnapshotFileDetails::SnapshotFileDetails(const SnapshotFileDetails& other) =
+    default;
+
 SnapshotFileDetails::~SnapshotFileDetails() {
   file_stream_.Release();
 }

chrome/browser/media_galleries/win/snapshot_file_details.h

@@ -18,6 +18,7 @@ struct SnapshotRequestInfo {
       const MTPDeviceAsyncDelegate::CreateSnapshotFileSuccessCallback&
           success_callback,
       const MTPDeviceAsyncDelegate::ErrorCallback& error_callback);
+  SnapshotRequestInfo(const SnapshotRequestInfo& other);
   ~SnapshotRequestInfo();
 
   // Device file path.
@@ -38,6 +39,7 @@ struct SnapshotRequestInfo {
 class SnapshotFileDetails {
  public:
   explicit SnapshotFileDetails(const SnapshotRequestInfo& request_info);
+  SnapshotFileDetails(const SnapshotFileDetails& other);
   ~SnapshotFileDetails();
 
   void set_file_info(const base::File::Info& file_info);

chrome/browser/net/service_providers_win.cc

@@ -16,6 +16,9 @@
 WinsockLayeredServiceProvider::WinsockLayeredServiceProvider() {
 }
 
+WinsockLayeredServiceProvider::WinsockLayeredServiceProvider(
+    const WinsockLayeredServiceProvider& other) = default;
+
 WinsockLayeredServiceProvider::~WinsockLayeredServiceProvider() {
 }
 

chrome/browser/net/service_providers_win.h

@@ -19,6 +19,7 @@ typedef std::vector<WinsockNamespaceProvider> WinsockNamespaceProviderList;
 
 struct WinsockLayeredServiceProvider {
   WinsockLayeredServiceProvider();
+  WinsockLayeredServiceProvider(const WinsockLayeredServiceProvider& other);
   ~WinsockLayeredServiceProvider();
 
   base::string16 name;

chrome/installer/util/shell_util.cc

@@ -1391,6 +1391,9 @@ ShellUtil::ShortcutProperties::ShortcutProperties(ShellChange level_in)
       pin_to_taskbar(false),
       options(0U) {}
 
+ShellUtil::ShortcutProperties::ShortcutProperties(
+    const ShortcutProperties& other) = default;
+
 ShellUtil::ShortcutProperties::~ShortcutProperties() {
 }
 

chrome/installer/util/shell_util.h

@@ -97,6 +97,7 @@ class ShellUtil {
     };
 
     explicit ShortcutProperties(ShellChange level_in);
+    ShortcutProperties(const ShortcutProperties& other);
     ~ShortcutProperties();
 
     // Sets the target executable to launch from this shortcut.

components/os_crypt/ie7_password_win.cc

@@ -55,6 +55,8 @@ struct PasswordEntry {
 IE7PasswordInfo::IE7PasswordInfo() {
 }
 
+IE7PasswordInfo::IE7PasswordInfo(const IE7PasswordInfo& other) = default;
+
 IE7PasswordInfo::~IE7PasswordInfo() {
 }
 

components/os_crypt/ie7_password_win.h

@@ -14,6 +14,7 @@
 // Contains the information read from the IE7/IE8 Storage2 key in the registry.
 struct IE7PasswordInfo {
   IE7PasswordInfo();
+  IE7PasswordInfo(const IE7PasswordInfo& other);
   ~IE7PasswordInfo();
 
   // Hash of the url.

components/storage_monitor/portable_device_watcher_win.cc

@@ -481,6 +481,9 @@ PortableDeviceWatcherWin::DeviceStorageObject::DeviceStorageObject(
 PortableDeviceWatcherWin::DeviceDetails::DeviceDetails() {
 }
 
+PortableDeviceWatcherWin::DeviceDetails::DeviceDetails(
+    const DeviceDetails& other) = default;
+
 PortableDeviceWatcherWin::DeviceDetails::~DeviceDetails() {
 }
 

components/storage_monitor/portable_device_watcher_win.h

@@ -53,6 +53,7 @@ class PortableDeviceWatcherWin {
   // Struct to store attached MTP device details.
   struct DeviceDetails {
     DeviceDetails();
+    DeviceDetails(const DeviceDetails& other);
     ~DeviceDetails();
 
     // Device name.

content/common/gpu/media/dxva_video_decode_accelerator_win.cc

@@ -891,6 +891,9 @@ DXVAVideoDecodeAccelerator::PendingSampleInfo::PendingSampleInfo(
   output_sample.Attach(sample);
 }
 
+DXVAVideoDecodeAccelerator::PendingSampleInfo::PendingSampleInfo(
+    const PendingSampleInfo& other) = default;
+
 DXVAVideoDecodeAccelerator::PendingSampleInfo::~PendingSampleInfo() {}
 
 DXVAVideoDecodeAccelerator::DXVAVideoDecodeAccelerator(

content/common/gpu/media/dxva_video_decode_accelerator_win.h

@@ -374,6 +374,7 @@ class CONTENT_EXPORT DXVAVideoDecodeAccelerator
   // Contains information about a decoded sample.
   struct PendingSampleInfo {
     PendingSampleInfo(int32_t buffer_id, IMFSample* sample);
+    PendingSampleInfo(const PendingSampleInfo& other);
     ~PendingSampleInfo();
 
     int32_t input_buffer_id;

content/test/dwrite_font_fake_sender_win.cc

@@ -38,6 +38,8 @@ IPC::Sender* CreateFakeCollectionSender() {
 
 FakeFont::FakeFont(const base::string16& name) : font_name_(name) {}
 
+FakeFont::FakeFont(const FakeFont& other) = default;
+
 FakeFont::~FakeFont() = default;
 
 FakeFontCollection::FakeFontCollection() = default;

content/test/dwrite_font_fake_sender_win.h

@@ -32,6 +32,8 @@ class FakeFont {
  public:
   explicit FakeFont(const base::string16& name);
 
+  FakeFont(const FakeFont& other);
+
   ~FakeFont();
 
   FakeFont& AddFilePath(const base::string16& file_path) {

media/capture/video/video_capture_device.cc

@@ -75,6 +75,8 @@ VideoCaptureDevice::Name::Name(const std::string& name,
 }
 #endif
 
+VideoCaptureDevice::Name::Name(const Name& other) = default;
+
 VideoCaptureDevice::Name::~Name() {
 }
 

media/capture/video/video_capture_device.h

@@ -93,6 +93,7 @@ class MEDIA_EXPORT VideoCaptureDevice {
          const CaptureApiType api_type,
          const TransportType transport_type);
 #endif
+    Name(const Name& other);
     ~Name();
 
     // Friendly name of a device

printing/backend/print_backend.cc

@@ -26,6 +26,9 @@ PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults()
       bw_model(UNKNOWN_COLOR_MODEL)
 {}
 
+PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults(
+    const PrinterSemanticCapsAndDefaults& other) = default;
+
 PrinterSemanticCapsAndDefaults::~PrinterSemanticCapsAndDefaults() {}
 
 PrinterCapsAndDefaults::PrinterCapsAndDefaults() {}

printing/backend/print_backend.h

@@ -37,6 +37,7 @@ typedef std::vector<PrinterBasicInfo> PrinterList;
 
 struct PRINTING_EXPORT PrinterSemanticCapsAndDefaults {
   PrinterSemanticCapsAndDefaults();
+  PrinterSemanticCapsAndDefaults(const PrinterSemanticCapsAndDefaults& other);
   ~PrinterSemanticCapsAndDefaults();
 
   bool collate_capable;

sandbox/win/src/interception.cc

@@ -67,6 +67,9 @@ const char kUnloadDLLDummyFunction[] = "@";
 InterceptionManager::InterceptionData::InterceptionData() {
 }
 
+InterceptionManager::InterceptionData::InterceptionData(
+    const InterceptionData& other) = default;
+
 InterceptionManager::InterceptionData::~InterceptionData() {
 }
 

sandbox/win/src/interception.h

@@ -137,6 +137,7 @@ class InterceptionManager {
   // Used to store the interception information until the actual set-up.
   struct InterceptionData {
     InterceptionData();
+    InterceptionData(const InterceptionData& other);
     ~InterceptionData();
 
     InterceptionType type;            // Interception type.