Skip to content

Commit

Permalink
Reenable LocalNTPVoiceSearchSmokeTest.MicrophonePermission
Browse files Browse the repository at this point in the history
This should have been fixed by https://crrev.com/c/1036230. The source
of the memory being leaked (creating the old IPC messages) was removed
by mojoification.

Bug: 838420
Change-Id: I115e390cbd458ee71c7eb679bc2f84fb2ee1d823
Reviewed-on: https://chromium-review.googlesource.com/1069120
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560656}
  • Loading branch information
a4sriniv authored and Commit Bot committed May 22, 2018
1 parent a936f8d commit b7716f4
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions chrome/browser/ui/search/local_ntp_voice_search_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,7 @@ IN_PROC_BROWSER_TEST_F(LocalNTPVoiceSearchSmokeTest,
EXPECT_TRUE(console_observer.message().empty()) << console_observer.message();
}

// Flakily leaks (and fails) on LSAN. crbug.com/838420
#if defined(LEAK_SANITIZER)
#define MAYBE_MicrophonePermission DISABLED_MicrophonePermission
#else
#define MAYBE_MicrophonePermission MicrophonePermission
#endif

IN_PROC_BROWSER_TEST_F(LocalNTPVoiceSearchSmokeTest,
MAYBE_MicrophonePermission) {
IN_PROC_BROWSER_TEST_F(LocalNTPVoiceSearchSmokeTest, MicrophonePermission) {
// Open a new NTP.
content::WebContents* active_tab = local_ntp_test_utils::OpenNewTab(
browser(), GURL(chrome::kChromeUINewTabURL));
Expand Down

0 comments on commit b7716f4

Please sign in to comment.