Skip to content

Commit

Permalink
Update virtual/final usage in url/.
Browse files Browse the repository at this point in the history
BUG=417463
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/658563010

Cr-Commit-Position: refs/heads/master@{#300620}
  • Loading branch information
viettrungluu-cr committed Oct 22, 2014
1 parent b9cc2b2 commit b424ebc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions url/url_canon_icu.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ class URL_EXPORT ICUCharsetConverter : public CharsetConverter {
// be managed by the creator such that it is alive as long as this is.
ICUCharsetConverter(UConverter* converter);

virtual ~ICUCharsetConverter();
~ICUCharsetConverter() override;

virtual void ConvertFromUTF16(const base::char16* input,
int input_len,
CanonOutput* output) override;
void ConvertFromUTF16(const base::char16* input,
int input_len,
CanonOutput* output) override;

private:
// The ICU converter, not owned by this class.
Expand Down
4 changes: 2 additions & 2 deletions url/url_canon_stdstring.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ namespace url {
class URL_EXPORT StdStringCanonOutput : public CanonOutput {
public:
StdStringCanonOutput(std::string* str);
virtual ~StdStringCanonOutput();
~StdStringCanonOutput() override;

// Must be called after writing has completed but before the string is used.
void Complete();

virtual void Resize(int sz) override;
void Resize(int sz) override;

protected:
std::string* str_;
Expand Down

0 comments on commit b424ebc

Please sign in to comment.