Skip to content

Commit

Permalink
Fix order of includes in base_nacl.gyp
Browse files Browse the repository at this point in the history
GYP wasn't generating correct list of dependencies when base.gypi was
included after untrusted.gypi. As result libbase_nacl.a wasn't always
rebuilt when the sources it depends on were changed.

BUG=461422

Review URL: https://codereview.chromium.org/976863002

Cr-Commit-Position: refs/heads/master@{#319092}
  • Loading branch information
SergeyUlanov authored and Commit bot committed Mar 4, 2015
1 parent 5ef8fe8 commit a446829
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion base/base_nacl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
'chromium_code': 1,
},
'includes': [
'../build/common_untrusted.gypi',
# base.gypi must be included before common_untrusted.gypi.
#
# TODO(sergeyu): Replace the target_defaults magic in base.gypi with a
# sources variables lists. That way order of includes will not matter.
'base.gypi',
'../build/common_untrusted.gypi',
],
'conditions': [
['disable_nacl==0 and disable_nacl_untrusted==0', {
Expand Down

0 comments on commit a446829

Please sign in to comment.