Skip to content

Commit

Permalink
Cross-platform CL to remove app/win/win_util.h&cc and related work.
Browse files Browse the repository at this point in the history
See Issue 70141 for the full move details; see my inline review comments.

Changes significantly different from or beyond those prescribed by the bug:
*Consolidated a lot of GrabWindowSnapshot code.
*Moved EnsureRectIsVisibleInRect to views::internal namespace for test access.
*Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h
*Named ui/base/message_box_win.h instead of ui/base/message_box.h
*Made WindowWin::GetWindowTitleFont static; needed in static contexts.
*Denoted WindowWin::FrameTypeChanged as a Window override, moved code.
*Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm

BUG=70141
TEST=none

Review URL: http://codereview.chromium.org/6386009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
msw@chromium.org committed Feb 3, 2011
1 parent 2aa8b71 commit 75b6805
Show file tree
Hide file tree
Showing 61 changed files with 811 additions and 770 deletions.
2 changes: 0 additions & 2 deletions app/app.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
'sql/statement_unittest.cc',
'sql/transaction_unittest.cc',
'test_suite.h',
'win/win_util_unittest.cc',
],
'include_dirs': [
'..',
Expand All @@ -79,7 +78,6 @@
'sources!': [
'../ui/base/dragdrop/os_exchange_data_win_unittest.cc',
'../ui/base/view_prop_unittest.cc',
'win_util_unittest.cc',
],
}],
['OS =="linux" or OS =="freebsd"', {
Expand Down
4 changes: 2 additions & 2 deletions app/app_base.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@
'../ui/base/l10n/l10n_util_win.cc',
'../ui/base/l10n/l10n_util_win.h',
'../ui/base/message_box_flags.h',
'../ui/base/message_box_win.cc',
'../ui/base/message_box_win.h',
'../ui/base/models/accelerator.h',
'../ui/base/models/accelerator_gtk.h',
'../ui/base/models/accelerator_cocoa.h',
Expand Down Expand Up @@ -242,8 +244,6 @@
'win/scoped_prop.h',
'win/shell.cc',
'win/shell.h',
'win/win_util.cc',
'win/win_util.h',
'<(gl_binding_output_dir)/gl_bindings_autogen_gl.cc',
'<(gl_binding_output_dir)/gl_bindings_autogen_gl.h',
'<(gl_binding_output_dir)/gl_bindings_autogen_mock.cc',
Expand Down
326 changes: 0 additions & 326 deletions app/win/win_util.cc

This file was deleted.

Loading

0 comments on commit 75b6805

Please sign in to comment.