Skip to content

Commit

Permalink
Split chrome/nacl/nacl_exe_win_64.cc
Browse files Browse the repository at this point in the history
    
 Move most of the content to the components/nacl folder and make sure it doesn't include anything from chrome. Setting the breakpad client is kept in chrome.
    
This is part of an effort to componentize NaCl code.

BUG=244791

Review URL: https://codereview.chromium.org/59263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235013 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
alexis.menard@intel.com committed Nov 14, 2013
1 parent f40dcd1 commit 6b492fd
Show file tree
Hide file tree
Showing 4 changed files with 101 additions and 71 deletions.
73 changes: 2 additions & 71 deletions chrome/nacl/nacl_exe_win_64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,9 @@
#include "base/at_exit.h"
#include "base/command_line.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
#include "base/power_monitor/power_monitor.h"
#include "base/power_monitor/power_monitor_device_source.h"
#include "base/process/launch.h"
#include "base/process/memory.h"
#include "base/strings/string_util.h"
#include "base/timer/hi_res_timer_manager.h"
#include "chrome/app/chrome_breakpad_client.h"
#include "chrome/common/chrome_result_codes.h"
#include "chrome/common/logging_chrome.h"
#include "components/breakpad/app/breakpad_client.h"
#include "components/breakpad/app/breakpad_win.h"
#include "components/nacl/broker/nacl_broker_listener.h"
#include "components/nacl/common/nacl_switches.h"
#include "components/nacl/loader/nacl_listener.h"
#include "components/nacl/loader/nacl_main_platform_delegate.h"
#include "content/public/app/startup_helper_win.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/main_function_params.h"
#include "content/public/common/sandbox_init.h"
#include "sandbox/win/src/sandbox_types.h"

extern int NaClMain(const content::MainFunctionParams&);
#include "components/nacl/loader/nacl_helper_win_64.h"

namespace {

Expand All @@ -37,60 +16,12 @@ base::LazyInstance<chrome::ChromeBreakpadClient>::Leaky

} // namespace

// main() routine for the NaCl broker process.
// This is necessary for supporting NaCl in Chrome on Win64.
int NaClBrokerMain(const content::MainFunctionParams& parameters) {
base::MessageLoopForIO main_message_loop;
base::PlatformThread::SetName("CrNaClBrokerMain");

scoped_ptr<base::PowerMonitorSource> power_monitor_source(
new base::PowerMonitorDeviceSource());
base::PowerMonitor power_monitor(power_monitor_source.Pass());
base::HighResolutionTimerManager hi_res_timer_manager;

NaClBrokerListener listener;
listener.Listen();

return 0;
}

int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t*, int) {
sandbox::SandboxInterfaceInfo sandbox_info = {0};
content::InitializeSandboxInfo(&sandbox_info);

base::AtExitManager exit_manager;
CommandLine::Init(0, NULL);

breakpad::SetBreakpadClient(g_chrome_breakpad_client.Pointer());
breakpad::InitCrashReporter();

const CommandLine& command_line = *CommandLine::ForCurrentProcess();
std::string process_type =
command_line.GetSwitchValueASCII(switches::kProcessType);

// Copy what ContentMain() does.
base::EnableTerminationOnHeapCorruption();
base::EnableTerminationOnOutOfMemory();
content::RegisterInvalidParamHandler();
content::SetupCRT(command_line);
// Route stdio to parent console (if any) or create one.
if (command_line.HasSwitch(switches::kEnableLogging))
base::RouteStdioToConsole();

// Initialize the sandbox for this process.
bool sandbox_initialized_ok = content::InitializeSandbox(&sandbox_info);
// Die if the sandbox can't be enabled.
CHECK(sandbox_initialized_ok) << "Error initializing sandbox for "
<< process_type;
content::MainFunctionParams main_params(command_line);
main_params.sandbox_info = &sandbox_info;

if (process_type == switches::kNaClLoaderProcess)
return NaClMain(main_params);

if (process_type == switches::kNaClBrokerProcess)
return NaClBrokerMain(main_params);

CHECK(false) << "Unknown NaCl 64 process.";
return -1;
return nacl::NaClWin64Main();
}
2 changes: 2 additions & 0 deletions components/nacl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@
'../components/nacl/broker/nacl_broker_listener.cc',
'../components/nacl/broker/nacl_broker_listener.h',
'../components/nacl/common/nacl_debug_exception_handler_win.cc',
'../components/nacl/loader/nacl_helper_win_64.cc',
'../components/nacl/loader/nacl_helper_win_64.h',
],
'include_dirs': [
'..',
Expand Down
83 changes: 83 additions & 0 deletions components/nacl/loader/nacl_helper_win_64.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "base/command_line.h"
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
#include "base/power_monitor/power_monitor.h"
#include "base/power_monitor/power_monitor_device_source.h"
#include "base/process/launch.h"
#include "base/process/memory.h"
#include "base/strings/string_util.h"
#include "base/timer/hi_res_timer_manager.h"
#include "components/nacl/broker/nacl_broker_listener.h"
#include "components/nacl/common/nacl_switches.h"
#include "components/nacl/loader/nacl_listener.h"
#include "components/nacl/loader/nacl_main_platform_delegate.h"
#include "content/public/app/startup_helper_win.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/main_function_params.h"
#include "content/public/common/sandbox_init.h"
#include "sandbox/win/src/sandbox_types.h"

extern int NaClMain(const content::MainFunctionParams&);

namespace {
// main() routine for the NaCl broker process.
// This is necessary for supporting NaCl in Chrome on Win64.
int NaClBrokerMain(const content::MainFunctionParams& parameters) {
base::MessageLoopForIO main_message_loop;
base::PlatformThread::SetName("CrNaClBrokerMain");

scoped_ptr<base::PowerMonitorSource> power_monitor_source(
new base::PowerMonitorDeviceSource());
base::PowerMonitor power_monitor(power_monitor_source.Pass());
base::HighResolutionTimerManager hi_res_timer_manager;

NaClBrokerListener listener;
listener.Listen();

return 0;
}

} // namespace

namespace nacl {

int NaClWin64Main() {
sandbox::SandboxInterfaceInfo sandbox_info = {0};
content::InitializeSandboxInfo(&sandbox_info);

const CommandLine& command_line = *CommandLine::ForCurrentProcess();
std::string process_type =
command_line.GetSwitchValueASCII(switches::kProcessType);

// Copy what ContentMain() does.
base::EnableTerminationOnHeapCorruption();
base::EnableTerminationOnOutOfMemory();
content::RegisterInvalidParamHandler();
content::SetupCRT(command_line);
// Route stdio to parent console (if any) or create one.
if (command_line.HasSwitch(switches::kEnableLogging))
base::RouteStdioToConsole();

// Initialize the sandbox for this process.
bool sandbox_initialized_ok = content::InitializeSandbox(&sandbox_info);
// Die if the sandbox can't be enabled.
CHECK(sandbox_initialized_ok) << "Error initializing sandbox for "
<< process_type;
content::MainFunctionParams main_params(command_line);
main_params.sandbox_info = &sandbox_info;

if (process_type == switches::kNaClLoaderProcess)
return NaClMain(main_params);

if (process_type == switches::kNaClBrokerProcess)
return NaClBrokerMain(main_params);

CHECK(false) << "Unknown NaCl 64 process.";
return -1;
}

} // namespace nacl
14 changes: 14 additions & 0 deletions components/nacl/loader/nacl_helper_win_64.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef COMPONENTS_NACL_LOADER_NACL_HELPER_WIN_64_H_
#define COMPONENTS_NACL_LOADER_NACL_HELPER_WIN_64_H_

namespace nacl {

int NaClWin64Main();

} // namespace nacl

#endif // COMPONENTS_NACL_LOADER_NACL_HELPER_WIN_64_H_

0 comments on commit 6b492fd

Please sign in to comment.