Skip to content

Commit

Permalink
Android: make the top level Android makefile smarter.
Browse files Browse the repository at this point in the history
Instead of requiring an environment variable to be set, which has
resulted in issues with things not being rebuilt correctly when the
variable is forgotten, check to see if the gyp-generated Android
makefile has been created, and if so assume we are doing a WebView
build. This file only exists if gyp has been run with
GYP_GENERATORS=android which only happens in the WebView tree.

Also, rename CHROMIUM_WEBVIEW_DIR to CHROMIUM_DIR as the directory
itself is not webview-specific; it's just the Chromium tree root.

BUG=

Review URL: https://codereview.chromium.org/11269007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164291 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
torne@chromium.org committed Oct 26, 2012
1 parent 6707540 commit 53cdffa
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@
# which prevents the Android build system from mistakenly loading any other
# Android.mk that may exist in the Chromium tree.

ifdef CHROME_ANDROID_BUILD_WEBVIEW
CHROMIUM_WEBVIEW_DIR := $(call my-dir)
include $(CHROMIUM_WEBVIEW_DIR)/GypAndroid.mk
include $(CHROMIUM_WEBVIEW_DIR)/android_webview/Android.mk
CHROMIUM_DIR := $(call my-dir)

# Assume that if the gyp autogenerated makefile exists, we are doing the
# WebView build using the Android build system.
ifneq (,$(wildcard $(CHROMIUM_DIR)/GypAndroid.mk))
include $(CHROMIUM_DIR)/GypAndroid.mk
include $(CHROMIUM_DIR)/android_webview/Android.mk
endif

0 comments on commit 53cdffa

Please sign in to comment.