From 51ba3e6902ecd7284d3be51db648127d1be2187f Mon Sep 17 00:00:00 2001 From: avi Date: Sat, 26 Dec 2015 09:30:50 -0800 Subject: [PATCH] Clean up header files. BUG=138542 TBR=ben@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1544283002 Cr-Commit-Position: refs/heads/master@{#366903} --- base/base_paths_android.cc | 1 + base/base_paths_posix.cc | 2 ++ base/logging.cc | 2 ++ base/process/process_handle_freebsd.cc | 1 + .../api/metrics_private/metrics_private_api.cc | 2 ++ .../api/music_manager_private/device_id_win.cc | 2 ++ .../api/streams_private/streams_private_api.cc | 2 ++ chrome/browser/extensions/api/tabs/tabs_test.cc | 1 + .../configuration_policy_handler_list_factory.cc | 1 + chrome/browser/process_singleton_posix_unittest.cc | 1 + .../incident_reporting/download_metadata_manager.cc | 1 + chrome/browser/safe_browsing/srt_fetcher_win.h | 2 ++ chrome/browser/signin/signin_promo.cc | 2 ++ chrome/browser/themes/browser_theme_pack.cc | 1 + chrome/browser/ui/views/omnibox/omnibox_result_view.cc | 3 +++ .../md_downloads/downloads_list_tracker_unittest.cc | 1 + chrome/browser/ui/webui/signin/inline_login_handler.cc | 2 ++ chrome/common/net/x509_certificate_model_openssl.cc | 1 + .../safe_browsing/protobuf_message_param_traits.h | 2 ++ chrome/test/logging/win/file_logger.cc | 1 + chrome/utility/cloud_print/pwg_encoder.cc | 1 + chrome/utility/safe_browsing/mac/crdmg.cc | 1 + components/crash/content/app/breakpad_mac.mm | 1 - .../android/cronet_url_request_context_adapter.cc | 1 + components/drive/resource_metadata.cc | 1 + components/mus/public/cpp/tests/window_unittest.cc | 1 + components/nacl/renderer/plugin/srpc_client.cc | 1 + components/policy/core/common/schema.cc | 1 + components/safe_browsing_db/prefix_set.cc | 2 ++ components/signin/core/browser/signin_metrics.cc | 2 ++ components/signin/core/browser/signin_metrics.h | 2 ++ components/ssl_errors/error_classification.cc | 1 + components/variations/metrics_util.cc | 2 ++ components/webcrypto/algorithms/aes_cbc_unittest.cc | 1 + components/webcrypto/algorithms/hmac_unittest.cc | 1 + components/webcrypto/webcrypto_impl.cc | 1 + content/plugin/plugin_interpose_util_mac.h | 2 -- gpu/command_buffer/client/query_tracker.h | 1 + gpu/command_buffer/service/gles2_cmd_decoder.cc | 1 + .../service/gles2_cmd_decoder_unittest_framebuffers.cc | 1 + gpu/command_buffer/service/sync_point_manager.cc | 1 + .../gl_chromium_framebuffer_mixed_samples_unittest.cc | 10 ++++++---- ipc/ipc_message_utils.h | 1 + net/base/ip_address_number.cc | 2 ++ net/base/sdch_manager.cc | 2 ++ net/cert/ct_log_verifier_unittest.cc | 4 +++- net/cert/internal/name_constraints.cc | 2 ++ net/cert/x509_certificate.cc | 1 + net/cert/x509_util_openssl.cc | 1 + net/disk_cache/blockfile/file_ios.cc | 1 + net/disk_cache/blockfile/file_win.cc | 2 ++ net/disk_cache/simple/simple_entry_operation.cc | 2 ++ net/dns/dns_util.cc | 1 + sandbox/linux/services/credentials.cc | 1 + sandbox/linux/services/credentials_unittest.cc | 1 + sandbox/win/src/handle_closer_agent.cc | 1 + sandbox/win/src/handle_closer_test.cc | 1 + sandbox/win/wow_helper/service64_resolver.cc | 1 + sql/connection.cc | 1 + sync/internal_api/public/base/ordinal.h | 2 +- ui/accessibility/platform/ax_platform_node_win.cc | 1 + ui/aura/window_unittest.cc | 2 ++ ui/base/l10n/formatter.cc | 2 ++ ui/base/win/accessibility_ids_win.h | 2 ++ ui/events/android/scroller_unittest.cc | 2 ++ ui/events/gestures/blink/web_gesture_curve_impl.cc | 2 ++ ui/gfx/canvas_skia.cc | 1 + ui/gfx/color_analysis.cc | 1 + ui/gfx/platform_font_win.cc | 1 + ui/gfx/render_text.cc | 2 ++ ui/gfx/render_text_unittest.cc | 1 + ui/surface/transport_dib.cc | 2 ++ ui/views/view_targeter_delegate.cc | 2 ++ url/url_canon_path.cc | 2 ++ 74 files changed, 108 insertions(+), 9 deletions(-) diff --git a/base/base_paths_android.cc b/base/base_paths_android.cc index 56c6cc70f474bd..ca58179b6782fd 100644 --- a/base/base_paths_android.cc +++ b/base/base_paths_android.cc @@ -5,6 +5,7 @@ // Defines base::PathProviderAndroid which replaces base::PathProviderPosix for // Android in base/path_service.cc. +#include #include #include "base/android/jni_android.h" diff --git a/base/base_paths_posix.cc b/base/base_paths_posix.cc index 048434f0ef75d0..4b847c47d14bb1 100644 --- a/base/base_paths_posix.cc +++ b/base/base_paths_posix.cc @@ -6,6 +6,8 @@ // don't have their own base_paths_OS.cc implementation (i.e. all but Mac and // Android). +#include + #include #include diff --git a/base/logging.cc b/base/logging.cc index 20bc7f51f23b0f..22e0aa0c6371fe 100644 --- a/base/logging.cc +++ b/base/logging.cc @@ -4,6 +4,8 @@ #include "base/logging.h" +#include + #if defined(OS_WIN) #include #include diff --git a/base/process/process_handle_freebsd.cc b/base/process/process_handle_freebsd.cc index 27af5f05791e47..192d72bcc56ac4 100644 --- a/base/process/process_handle_freebsd.cc +++ b/base/process/process_handle_freebsd.cc @@ -5,6 +5,7 @@ #include "base/macros.h" #include "base/process/process_handle.h" +#include #include #include #include diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc index 2668215b30a768..141e926e543ef6 100644 --- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc +++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc @@ -4,6 +4,8 @@ #include "chrome/browser/extensions/api/metrics_private/metrics_private_api.h" +#include + #include #include "base/metrics/field_trial.h" diff --git a/chrome/browser/extensions/api/music_manager_private/device_id_win.cc b/chrome/browser/extensions/api/music_manager_private/device_id_win.cc index 594ec85ed1d3d6..64caf3b83f2027 100644 --- a/chrome/browser/extensions/api/music_manager_private/device_id_win.cc +++ b/chrome/browser/extensions/api/music_manager_private/device_id_win.cc @@ -7,6 +7,8 @@ // Note: The order of header includes is important, as we want both pre-Vista // and post-Vista data structures to be defined, specifically // PIP_ADAPTER_ADDRESSES and PMIB_IF_ROW2. + +#include #include #include #include diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc index b85d2fb890f922..d222b75ee349fe 100644 --- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc +++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc @@ -4,6 +4,8 @@ #include "chrome/browser/extensions/api/streams_private/streams_private_api.h" +#include + #include "base/lazy_instance.h" #include "base/values.h" #include "chrome/browser/extensions/extension_tab_util.h" diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc index 81f7d59ab777e8..a4c72ad737d00b 100644 --- a/chrome/browser/extensions/api/tabs/tabs_test.cc +++ b/chrome/browser/extensions/api/tabs/tabs_test.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include #include #include diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc index a7d1666fff3ce8..9a4858f0a0ac00 100644 --- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc +++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc @@ -4,6 +4,7 @@ #include "chrome/browser/policy/configuration_policy_handler_list_factory.h" +#include #include #include "base/bind.h" diff --git a/chrome/browser/process_singleton_posix_unittest.cc b/chrome/browser/process_singleton_posix_unittest.cc index 8fc6fff738998b..4ab97b96ddd591 100644 --- a/chrome/browser/process_singleton_posix_unittest.cc +++ b/chrome/browser/process_singleton_posix_unittest.cc @@ -5,6 +5,7 @@ #include "chrome/browser/process_singleton.h" #include +#include #include #include #include diff --git a/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc b/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc index b7e7ba7fd7c377..4c4943a29214f1 100644 --- a/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc +++ b/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc @@ -4,6 +4,7 @@ #include "chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.h" +#include #include #include diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h index a2e180b885d88c..2f9db522614227 100644 --- a/chrome/browser/safe_browsing/srt_fetcher_win.h +++ b/chrome/browser/safe_browsing/srt_fetcher_win.h @@ -5,6 +5,8 @@ #ifndef CHROME_BROWSER_SAFE_BROWSING_SRT_FETCHER_WIN_H_ #define CHROME_BROWSER_SAFE_BROWSING_SRT_FETCHER_WIN_H_ +#include + #include #include "base/callback_forward.h" diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc index 0425f29ccdb36f..1a78b1883bbd52 100644 --- a/chrome/browser/signin/signin_promo.cc +++ b/chrome/browser/signin/signin_promo.cc @@ -4,6 +4,8 @@ #include "chrome/browser/signin/signin_promo.h" +#include + #include "base/prefs/pref_service.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_util.h" diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc index 9d225c34148647..0002a5b07d0660 100644 --- a/chrome/browser/themes/browser_theme_pack.cc +++ b/chrome/browser/themes/browser_theme_pack.cc @@ -4,6 +4,7 @@ #include "chrome/browser/themes/browser_theme_pack.h" +#include #include #include diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc index b74b097cd37f16..6e5493a8aac6c7 100644 --- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc +++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc @@ -4,6 +4,7 @@ // For WinDDK ATL compatibility, these ATL headers must come first. #include "build/build_config.h" + #if defined(OS_WIN) #include // NOLINT #include // NOLINT @@ -12,6 +13,8 @@ #include "base/macros.h" #include "chrome/browser/ui/views/omnibox/omnibox_result_view.h" +#include + #include // NOLINT #include "base/i18n/bidi_line_iterator.h" diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc index 3e9d0a8e0c228e..2cc4df24ab8a03 100644 --- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc +++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc @@ -4,6 +4,7 @@ #include "chrome/browser/ui/webui/md_downloads/downloads_list_tracker.h" +#include #include #include diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc index a4df00df057128..8655905836f3f2 100644 --- a/chrome/browser/ui/webui/signin/inline_login_handler.cc +++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc @@ -4,6 +4,8 @@ #include "chrome/browser/ui/webui/signin/inline_login_handler.h" +#include + #include "base/bind.h" #include "base/prefs/pref_service.h" #include "base/strings/string_number_conversions.h" diff --git a/chrome/common/net/x509_certificate_model_openssl.cc b/chrome/common/net/x509_certificate_model_openssl.cc index d549c9a851c8e5..cf99faae4f9985 100644 --- a/chrome/common/net/x509_certificate_model_openssl.cc +++ b/chrome/common/net/x509_certificate_model_openssl.cc @@ -4,6 +4,7 @@ #include "chrome/common/net/x509_certificate_model.h" +#include #include #include #include diff --git a/chrome/common/safe_browsing/protobuf_message_param_traits.h b/chrome/common/safe_browsing/protobuf_message_param_traits.h index 46890e41aff2d4..f78dfec6f9502b 100644 --- a/chrome/common/safe_browsing/protobuf_message_param_traits.h +++ b/chrome/common/safe_browsing/protobuf_message_param_traits.h @@ -5,6 +5,8 @@ #ifndef CHROME_COMMON_SAFE_BROWSING_PROTOBUF_MESSAGE_PARAM_TRAITS_H_ #define CHROME_COMMON_SAFE_BROWSING_PROTOBUF_MESSAGE_PARAM_TRAITS_H_ +#include + #include #include "base/pickle.h" diff --git a/chrome/test/logging/win/file_logger.cc b/chrome/test/logging/win/file_logger.cc index e1e5ab99ddde77..13eca7bb33675a 100644 --- a/chrome/test/logging/win/file_logger.cc +++ b/chrome/test/logging/win/file_logger.cc @@ -4,6 +4,7 @@ #include "chrome/test/logging/win/file_logger.h" +#include #include #include #include diff --git a/chrome/utility/cloud_print/pwg_encoder.cc b/chrome/utility/cloud_print/pwg_encoder.cc index 262777483fc90f..c0a9959b5b717b 100644 --- a/chrome/utility/cloud_print/pwg_encoder.cc +++ b/chrome/utility/cloud_print/pwg_encoder.cc @@ -4,6 +4,7 @@ #include "chrome/utility/cloud_print/pwg_encoder.h" +#include #include #include diff --git a/chrome/utility/safe_browsing/mac/crdmg.cc b/chrome/utility/safe_browsing/mac/crdmg.cc index 19fc3433ae18d1..a6cb076fcd63c8 100644 --- a/chrome/utility/safe_browsing/mac/crdmg.cc +++ b/chrome/utility/safe_browsing/mac/crdmg.cc @@ -4,6 +4,7 @@ #include #include +#include #include #include #include diff --git a/components/crash/content/app/breakpad_mac.mm b/components/crash/content/app/breakpad_mac.mm index 79e4d7b52c3ca7..6c6934bfa7ea83 100644 --- a/components/crash/content/app/breakpad_mac.mm +++ b/components/crash/content/app/breakpad_mac.mm @@ -11,7 +11,6 @@ #include "base/auto_reset.h" #include "base/base_switches.h" -#import "base/basictypes.h" #include "base/command_line.h" #include "base/debug/crash_logging.h" #include "base/debug/dump_without_crashing.h" diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc index ff6f2414225464..7ed7f6c5387cb6 100644 --- a/components/cronet/android/cronet_url_request_context_adapter.cc +++ b/components/cronet/android/cronet_url_request_context_adapter.cc @@ -4,6 +4,7 @@ #include "components/cronet/android/cronet_url_request_context_adapter.h" +#include #include #include diff --git a/components/drive/resource_metadata.cc b/components/drive/resource_metadata.cc index fc6b899540e0b1..cbbc5adda1d835 100644 --- a/components/drive/resource_metadata.cc +++ b/components/drive/resource_metadata.cc @@ -4,6 +4,7 @@ #include "components/drive/resource_metadata.h" +#include #include #include "base/bind.h" diff --git a/components/mus/public/cpp/tests/window_unittest.cc b/components/mus/public/cpp/tests/window_unittest.cc index 48bd59932ce2c1..9df5b3f400a80b 100644 --- a/components/mus/public/cpp/tests/window_unittest.cc +++ b/components/mus/public/cpp/tests/window_unittest.cc @@ -4,6 +4,7 @@ #include "components/mus/public/cpp/window.h" +#include #include #include "base/logging.h" diff --git a/components/nacl/renderer/plugin/srpc_client.cc b/components/nacl/renderer/plugin/srpc_client.cc index ce92aac3e32340..a67772a6d34251 100644 --- a/components/nacl/renderer/plugin/srpc_client.cc +++ b/components/nacl/renderer/plugin/srpc_client.cc @@ -6,6 +6,7 @@ #include "components/nacl/renderer/plugin/srpc_client.h" +#include #include #include diff --git a/components/policy/core/common/schema.cc b/components/policy/core/common/schema.cc index 235eaca7a0e724..7eedffd0c61a31 100644 --- a/components/policy/core/common/schema.cc +++ b/components/policy/core/common/schema.cc @@ -4,6 +4,7 @@ #include "components/policy/core/common/schema.h" +#include #include #include diff --git a/components/safe_browsing_db/prefix_set.cc b/components/safe_browsing_db/prefix_set.cc index b5c97d3a395209..7e63a9e9decace 100644 --- a/components/safe_browsing_db/prefix_set.cc +++ b/components/safe_browsing_db/prefix_set.cc @@ -4,6 +4,8 @@ #include "components/safe_browsing_db/prefix_set.h" +#include + #include #include "base/files/file_util.h" diff --git a/components/signin/core/browser/signin_metrics.cc b/components/signin/core/browser/signin_metrics.cc index e0fe72c6d90268..78d415dd4d8a85 100644 --- a/components/signin/core/browser/signin_metrics.cc +++ b/components/signin/core/browser/signin_metrics.cc @@ -4,6 +4,8 @@ #include "components/signin/core/browser/signin_metrics.h" +#include + #include "base/logging.h" #include "base/metrics/histogram_macros.h" #include "base/metrics/user_metrics.h" diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h index 0327c06f19a89a..ff22f8449d1b5a 100644 --- a/components/signin/core/browser/signin_metrics.h +++ b/components/signin/core/browser/signin_metrics.h @@ -7,6 +7,8 @@ #include "base/time/time.h" +#include + #include "google_apis/gaia/google_service_auth_error.h" namespace signin_metrics { diff --git a/components/ssl_errors/error_classification.cc b/components/ssl_errors/error_classification.cc index 1397c1e4c84e55..75104f85965e1f 100644 --- a/components/ssl_errors/error_classification.cc +++ b/components/ssl_errors/error_classification.cc @@ -4,6 +4,7 @@ #include "components/ssl_errors/error_classification.h" +#include #include #include diff --git a/components/variations/metrics_util.cc b/components/variations/metrics_util.cc index e6e76e3f128949..52fa0be09c6caa 100644 --- a/components/variations/metrics_util.cc +++ b/components/variations/metrics_util.cc @@ -4,6 +4,8 @@ #include "components/variations/metrics_util.h" +#include + #include "base/sha1.h" #include "base/sys_byteorder.h" diff --git a/components/webcrypto/algorithms/aes_cbc_unittest.cc b/components/webcrypto/algorithms/aes_cbc_unittest.cc index 26af37d7dff981..ae7ad52dba9a5e 100644 --- a/components/webcrypto/algorithms/aes_cbc_unittest.cc +++ b/components/webcrypto/algorithms/aes_cbc_unittest.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include #include #include diff --git a/components/webcrypto/algorithms/hmac_unittest.cc b/components/webcrypto/algorithms/hmac_unittest.cc index b0381d38d15419..6b653028453f45 100644 --- a/components/webcrypto/algorithms/hmac_unittest.cc +++ b/components/webcrypto/algorithms/hmac_unittest.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include #include #include diff --git a/components/webcrypto/webcrypto_impl.cc b/components/webcrypto/webcrypto_impl.cc index cfa880c34639c2..3e3d49dda7b7f9 100644 --- a/components/webcrypto/webcrypto_impl.cc +++ b/components/webcrypto/webcrypto_impl.cc @@ -4,6 +4,7 @@ #include "components/webcrypto/webcrypto_impl.h" +#include #include #include "base/bind.h" diff --git a/content/plugin/plugin_interpose_util_mac.h b/content/plugin/plugin_interpose_util_mac.h index 1a6eb9ffd58079..ce8effb33f9ca1 100644 --- a/content/plugin/plugin_interpose_util_mac.h +++ b/content/plugin/plugin_interpose_util_mac.h @@ -5,8 +5,6 @@ #ifndef CONTENT_PLUGIN_PLUGIN_INTERPOSE_UTIL_MAC_H_ #define CONTENT_PLUGIN_PLUGIN_INTERPOSE_UTIL_MAC_H_ -#import "base/basictypes.h" - namespace mac_plugin_interposing { // Swizzles methods we need to watch in order to manage process and window diff --git a/gpu/command_buffer/client/query_tracker.h b/gpu/command_buffer/client/query_tracker.h index 35d4a476fcab36..c4505f1d55bcea 100644 --- a/gpu/command_buffer/client/query_tracker.h +++ b/gpu/command_buffer/client/query_tracker.h @@ -6,6 +6,7 @@ #define GPU_COMMAND_BUFFER_CLIENT_QUERY_TRACKER_H_ #include +#include #include #include diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc index 7c47ee80533155..3e603215a90a76 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder.cc +++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc @@ -4,6 +4,7 @@ #include "gpu/command_buffer/service/gles2_cmd_decoder.h" +#include #include #include #include diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc index 5d142515835ae4..9fc0a967f9ab1a 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc +++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc @@ -4,6 +4,7 @@ #include "gpu/command_buffer/service/gles2_cmd_decoder.h" +#include #include #include diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc index 435d0b245fbb74..97ba99383c8590 100644 --- a/gpu/command_buffer/service/sync_point_manager.cc +++ b/gpu/command_buffer/service/sync_point_manager.cc @@ -4,6 +4,7 @@ #include "gpu/command_buffer/service/sync_point_manager.h" +#include #include #include diff --git a/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc b/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc index 2297aee15da8a5..aa9a2a4e46575c 100644 --- a/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc +++ b/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc @@ -5,6 +5,8 @@ #include #include #include +#include +#include #include "base/command_line.h" #include "gpu/command_buffer/service/gpu_switches.h" @@ -173,7 +175,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, CoverageModulation) { } static const float kBlue[] = {0.0f, 0.0f, 1.0f, 1.0f}; static const float kGreen[] = {0.0f, 1.0f, 0.0f, 1.0f}; - scoped_ptr results[3]; + scoped_ptr results[3]; const GLint kResultSize = kWidth * kHeight * 4; for (int pass = 0; pass < 3; ++pass) { @@ -190,7 +192,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, CoverageModulation) { glCoverageModulationCHROMIUM(GL_NONE); } - results[pass].reset(new uint8[kResultSize]); + results[pass].reset(new uint8_t[kResultSize]); memset(results[pass].get(), GLTestHelper::kCheckClearValue, kResultSize); glReadPixels(0, 0, kWidth, kHeight, GL_RGBA, GL_UNSIGNED_BYTE, results[pass].get()); @@ -213,7 +215,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, MultisampleStencilEffective) { static const float kBlue[] = {0.0f, 0.0f, 1.0f, 1.0f}; static const float kGreen[] = {0.0f, 1.0f, 0.0f, 1.0f}; - scoped_ptr results[3]; + scoped_ptr results[3]; const GLint kResultSize = kWidth * kHeight * 4; for (int pass = 0; pass < 3; ++pass) { @@ -228,7 +230,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, MultisampleStencilEffective) { glUniform4fv(color_loc_, 1, kBlue); glDrawArrays(GL_TRIANGLES, 3, 3); - results[pass].reset(new uint8[kResultSize]); + results[pass].reset(new uint8_t[kResultSize]); memset(results[pass].get(), GLTestHelper::kCheckClearValue, kResultSize); glReadPixels(0, 0, kWidth, kHeight, GL_RGBA, GL_UNSIGNED_BYTE, results[pass].get()); diff --git a/ipc/ipc_message_utils.h b/ipc/ipc_message_utils.h index 3d68879e1bca19..69ea7cb6d8a08e 100644 --- a/ipc/ipc_message_utils.h +++ b/ipc/ipc_message_utils.h @@ -5,6 +5,7 @@ #ifndef IPC_IPC_MESSAGE_UTILS_H_ #define IPC_IPC_MESSAGE_UTILS_H_ +#include #include #include diff --git a/net/base/ip_address_number.cc b/net/base/ip_address_number.cc index 61af0679529f7c..1e44b7d3b1ebcc 100644 --- a/net/base/ip_address_number.cc +++ b/net/base/ip_address_number.cc @@ -4,6 +4,8 @@ #include "net/base/ip_address_number.h" +#include + #include "base/logging.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_piece.h" diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc index 9bb8e7e0f1b9f8..a8272700d955fd 100644 --- a/net/base/sdch_manager.cc +++ b/net/base/sdch_manager.cc @@ -4,6 +4,8 @@ #include "net/base/sdch_manager.h" +#include + #include #include "base/base64url.h" diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc index 9eaa6399715283..00412e5ed7f439 100644 --- a/net/cert/ct_log_verifier_unittest.cc +++ b/net/cert/ct_log_verifier_unittest.cc @@ -4,6 +4,8 @@ #include "net/cert/ct_log_verifier.h" +#include + #include #include "base/strings/string_number_conversions.h" @@ -92,7 +94,7 @@ const ProofTestVector kSHA256Proofs[4] = { // Decodes a hexadecimal string into the binary data it represents. std::string HexToBytes(const char* hex_data, size_t hex_data_length) { - std::vector output; + std::vector output; std::string result; std::string hex_data_input(hex_data, hex_data_length); if (base::HexStringToBytes(hex_data, &output)) diff --git a/net/cert/internal/name_constraints.cc b/net/cert/internal/name_constraints.cc index 07e231e4d2331c..ade43a776ee113 100644 --- a/net/cert/internal/name_constraints.cc +++ b/net/cert/internal/name_constraints.cc @@ -4,6 +4,8 @@ #include "net/cert/internal/name_constraints.h" +#include + #include "base/strings/string_util.h" #include "net/cert/internal/verify_name_match.h" #include "net/der/input.h" diff --git a/net/cert/x509_certificate.cc b/net/cert/x509_certificate.cc index 23786cfa0ccd85..d925ce6b490b14 100644 --- a/net/cert/x509_certificate.cc +++ b/net/cert/x509_certificate.cc @@ -4,6 +4,7 @@ #include "net/cert/x509_certificate.h" +#include #include #include diff --git a/net/cert/x509_util_openssl.cc b/net/cert/x509_util_openssl.cc index 7eb86a49f3f318..c81a3a49b39b01 100644 --- a/net/cert/x509_util_openssl.cc +++ b/net/cert/x509_util_openssl.cc @@ -4,6 +4,7 @@ #include "net/cert/x509_util_openssl.h" +#include #include #include diff --git a/net/disk_cache/blockfile/file_ios.cc b/net/disk_cache/blockfile/file_ios.cc index 96c988fef914f9..d1d1919f1dd719 100644 --- a/net/disk_cache/blockfile/file_ios.cc +++ b/net/disk_cache/blockfile/file_ios.cc @@ -4,6 +4,7 @@ #include "net/disk_cache/blockfile/file.h" +#include #include #include diff --git a/net/disk_cache/blockfile/file_win.cc b/net/disk_cache/blockfile/file_win.cc index 81f8cf86fa86d9..ef7be4308d15a1 100644 --- a/net/disk_cache/blockfile/file_win.cc +++ b/net/disk_cache/blockfile/file_win.cc @@ -4,6 +4,8 @@ #include "net/disk_cache/blockfile/file.h" +#include + #include "base/files/file_path.h" #include "base/lazy_instance.h" #include "base/message_loop/message_loop.h" diff --git a/net/disk_cache/simple/simple_entry_operation.cc b/net/disk_cache/simple/simple_entry_operation.cc index c17762c7126043..ce8b09c8fa273a 100644 --- a/net/disk_cache/simple/simple_entry_operation.cc +++ b/net/disk_cache/simple/simple_entry_operation.cc @@ -4,6 +4,8 @@ #include "net/disk_cache/simple/simple_entry_operation.h" +#include + #include "base/logging.h" #include "net/base/io_buffer.h" #include "net/disk_cache/disk_cache.h" diff --git a/net/dns/dns_util.cc b/net/dns/dns_util.cc index 4142a020b242cb..d2897ff2ae0438 100644 --- a/net/dns/dns_util.cc +++ b/net/dns/dns_util.cc @@ -5,6 +5,7 @@ #include "net/dns/dns_util.h" #include +#include #include diff --git a/sandbox/linux/services/credentials.cc b/sandbox/linux/services/credentials.cc index de5f8c4102a73b..fb6b6b4acab163 100644 --- a/sandbox/linux/services/credentials.cc +++ b/sandbox/linux/services/credentials.cc @@ -5,6 +5,7 @@ #include "sandbox/linux/services/credentials.h" #include +#include #include #include #include diff --git a/sandbox/linux/services/credentials_unittest.cc b/sandbox/linux/services/credentials_unittest.cc index 39fd6a7e6def2f..d666a0c147f5ec 100644 --- a/sandbox/linux/services/credentials_unittest.cc +++ b/sandbox/linux/services/credentials_unittest.cc @@ -6,6 +6,7 @@ #include #include +#include #include #include #include diff --git a/sandbox/win/src/handle_closer_agent.cc b/sandbox/win/src/handle_closer_agent.cc index 5face9bdf630a7..6b17f6547a8682 100644 --- a/sandbox/win/src/handle_closer_agent.cc +++ b/sandbox/win/src/handle_closer_agent.cc @@ -4,6 +4,7 @@ #include "sandbox/win/src/handle_closer_agent.h" +#include #include #include "base/logging.h" diff --git a/sandbox/win/src/handle_closer_test.cc b/sandbox/win/src/handle_closer_test.cc index c144ac37e5a13b..ceba818a7f4bb0 100644 --- a/sandbox/win/src/handle_closer_test.cc +++ b/sandbox/win/src/handle_closer_test.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include #include #include "base/strings/stringprintf.h" diff --git a/sandbox/win/wow_helper/service64_resolver.cc b/sandbox/win/wow_helper/service64_resolver.cc index 32c98294fa8a86..b5b67cc69702b9 100644 --- a/sandbox/win/wow_helper/service64_resolver.cc +++ b/sandbox/win/wow_helper/service64_resolver.cc @@ -4,6 +4,7 @@ #include "sandbox/win/wow_helper/service64_resolver.h" +#include #include #include "base/memory/scoped_ptr.h" diff --git a/sql/connection.cc b/sql/connection.cc index 88acef040d0981..4d23f7df06d292 100644 --- a/sql/connection.cc +++ b/sql/connection.cc @@ -4,6 +4,7 @@ #include "sql/connection.h" +#include #include #include #include diff --git a/sync/internal_api/public/base/ordinal.h b/sync/internal_api/public/base/ordinal.h index 6c0f21f021481d..81798a4ea8d348 100644 --- a/sync/internal_api/public/base/ordinal.h +++ b/sync/internal_api/public/base/ordinal.h @@ -35,7 +35,7 @@ namespace syncer { // // The Traits class should look like the following: // -// // Don't forget to #include "base/basictypes.h". +// // Don't forget to #include and . // struct MyOrdinalTraits { // // There must be at least two distinct values greater than kZeroDigit // // and less than kMaxDigit. diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc index 51bfed9f348ea5..ee7a4f9f8c6981 100644 --- a/ui/accessibility/platform/ax_platform_node_win.cc +++ b/ui/accessibility/platform/ax_platform_node_win.cc @@ -4,6 +4,7 @@ #include #include +#include #include #include diff --git a/ui/aura/window_unittest.cc b/ui/aura/window_unittest.cc index 8df4db54714d58..60792c2a4b7267 100644 --- a/ui/aura/window_unittest.cc +++ b/ui/aura/window_unittest.cc @@ -4,6 +4,8 @@ #include "ui/aura/window.h" +#include + #include #include #include diff --git a/ui/base/l10n/formatter.cc b/ui/base/l10n/formatter.cc index 3834d0ff16d5b6..94a83a49a03a9b 100644 --- a/ui/base/l10n/formatter.cc +++ b/ui/base/l10n/formatter.cc @@ -4,6 +4,8 @@ #include "ui/base/l10n/formatter.h" +#include + #include #include "base/logging.h" diff --git a/ui/base/win/accessibility_ids_win.h b/ui/base/win/accessibility_ids_win.h index af8041ce7e112a..6b07de52d6b0d1 100644 --- a/ui/base/win/accessibility_ids_win.h +++ b/ui/base/win/accessibility_ids_win.h @@ -4,6 +4,8 @@ #ifndef UI_BASE_WIN_ACCESSIBILITY_IDS_WIN_H_ #define UI_BASE_WIN_ACCESSIBILITY_IDS_WIN_H_ +#include + namespace base { namespace win { diff --git a/ui/events/android/scroller_unittest.cc b/ui/events/android/scroller_unittest.cc index 759984e9ed5422..21dae882a6d683 100644 --- a/ui/events/android/scroller_unittest.cc +++ b/ui/events/android/scroller_unittest.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include + #include "base/time/time.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/events/android/scroller.h" diff --git a/ui/events/gestures/blink/web_gesture_curve_impl.cc b/ui/events/gestures/blink/web_gesture_curve_impl.cc index e0a2f389eeafca..8288e5de7b4c00 100644 --- a/ui/events/gestures/blink/web_gesture_curve_impl.cc +++ b/ui/events/gestures/blink/web_gesture_curve_impl.cc @@ -4,6 +4,8 @@ #include "ui/events/gestures/blink/web_gesture_curve_impl.h" +#include + #include #include "base/logging.h" diff --git a/ui/gfx/canvas_skia.cc b/ui/gfx/canvas_skia.cc index 60daeefe3d5665..8f45fce059c542 100644 --- a/ui/gfx/canvas_skia.cc +++ b/ui/gfx/canvas_skia.cc @@ -4,6 +4,7 @@ #include "ui/gfx/canvas.h" +#include #include #include diff --git a/ui/gfx/color_analysis.cc b/ui/gfx/color_analysis.cc index 94eac52f15f5e8..445069366e4a27 100644 --- a/ui/gfx/color_analysis.cc +++ b/ui/gfx/color_analysis.cc @@ -4,6 +4,7 @@ #include "ui/gfx/color_analysis.h" +#include #include #include diff --git a/ui/gfx/platform_font_win.cc b/ui/gfx/platform_font_win.cc index 894aec2d1ed3f2..8646beb06100d0 100644 --- a/ui/gfx/platform_font_win.cc +++ b/ui/gfx/platform_font_win.cc @@ -6,6 +6,7 @@ #include #include +#include #include #include #include diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc index 00c6bb0dbc06ad..1757575b32f7a5 100644 --- a/ui/gfx/render_text.cc +++ b/ui/gfx/render_text.cc @@ -4,6 +4,8 @@ #include "ui/gfx/render_text.h" +#include + #include #include diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc index b24c1be5ba8ec0..51e1ac7a86196d 100644 --- a/ui/gfx/render_text_unittest.cc +++ b/ui/gfx/render_text_unittest.cc @@ -4,6 +4,7 @@ #include "ui/gfx/render_text.h" +#include #include #include diff --git a/ui/surface/transport_dib.cc b/ui/surface/transport_dib.cc index 3cbd90c7077788..b0f9193b2c2502 100644 --- a/ui/surface/transport_dib.cc +++ b/ui/surface/transport_dib.cc @@ -4,6 +4,8 @@ #include "ui/surface/transport_dib.h" +#include + #include "skia/ext/platform_canvas.h" // static diff --git a/ui/views/view_targeter_delegate.cc b/ui/views/view_targeter_delegate.cc index c672f504534666..b20842f120074e 100644 --- a/ui/views/view_targeter_delegate.cc +++ b/ui/views/view_targeter_delegate.cc @@ -4,6 +4,8 @@ #include "ui/views/view_targeter_delegate.h" +#include + #include "ui/gfx/geometry/rect_conversions.h" #include "ui/views/rect_based_targeting_utils.h" #include "ui/views/view.h" diff --git a/url/url_canon_path.cc b/url/url_canon_path.cc index 6e5bfb1a245fe4..2e088a03fc2eec 100644 --- a/url/url_canon_path.cc +++ b/url/url_canon_path.cc @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include + #include "base/logging.h" #include "url/url_canon.h" #include "url/url_canon_internal.h"