Clean up header files.

BUG=138542 TBR=ben@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1544283002 Cr-Commit-Position: refs/heads/master@{#366903}
cbchan · Dec 26, 2015 · 51ba3e6 · 51ba3e6
1 parent 0d65fb8
commit 51ba3e6
Show file tree

Hide file tree

Showing 74 changed files with 108 additions and 9 deletions.
diff --git a/base/base_paths_android.cc b/base/base_paths_android.cc
@@ -5,6 +5,7 @@
 // Defines base::PathProviderAndroid which replaces base::PathProviderPosix for
 // Android in base/path_service.cc.
 
+#include <limits.h>
 #include <unistd.h>
 
 #include "base/android/jni_android.h"

diff --git a/base/base_paths_posix.cc b/base/base_paths_posix.cc
@@ -6,6 +6,8 @@
 // don't have their own base_paths_OS.cc implementation (i.e. all but Mac and
 // Android).
 
+#include <limits.h>
+
 #include <ostream>
 #include <string>
 

diff --git a/base/logging.cc b/base/logging.cc
@@ -4,6 +4,8 @@
 
 #include "base/logging.h"
 
+#include <limits.h>
+
 #if defined(OS_WIN)
 #include <io.h>
 #include <windows.h>

diff --git a/base/process/process_handle_freebsd.cc b/base/process/process_handle_freebsd.cc
@@ -5,6 +5,7 @@
 #include "base/macros.h"
 #include "base/process/process_handle.h"
 
+#include <limits.h>
 #include <stddef.h>
 #include <sys/sysctl.h>
 #include <sys/types.h>

diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/extensions/api/metrics_private/metrics_private_api.h"
 
+#include <limits.h>
+
 #include <algorithm>
 
 #include "base/metrics/field_trial.h"

diff --git a/chrome/browser/extensions/api/music_manager_private/device_id_win.cc b/chrome/browser/extensions/api/music_manager_private/device_id_win.cc
@@ -7,6 +7,8 @@
 // Note: The order of header includes is important, as we want both pre-Vista
 // and post-Vista data structures to be defined, specifically
 // PIP_ADAPTER_ADDRESSES and PMIB_IF_ROW2.
+
+#include <limits.h>
 #include <stddef.h>
 #include <winsock2.h>
 #include <ws2def.h>

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/extensions/api/streams_private/streams_private_api.h"
 
+#include <limits.h>
+
 #include "base/lazy_instance.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_tab_util.h"

diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include "base/bind.h"

diff --git a/chrome/browser/process_singleton_posix_unittest.cc b/chrome/browser/process_singleton_posix_unittest.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/process_singleton.h"
 
 #include <fcntl.h>
+#include <limits.h>
 #include <signal.h>
 #include <stddef.h>
 #include <sys/types.h>

diff --git a/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc b/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.h"
 
+#include <limits.h>
 #include <stdint.h>
 
 #include <list>

diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.h b/chrome/browser/safe_browsing/srt_fetcher_win.h
@@ -5,6 +5,8 @@
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SRT_FETCHER_WIN_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SRT_FETCHER_WIN_H_
 
+#include <limits.h>
+
 #include <string>
 
 #include "base/callback_forward.h"

diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/signin/signin_promo.h"
 
+#include <limits.h>
+
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"

diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/themes/browser_theme_pack.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include <limits>

diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
@@ -4,6 +4,7 @@
 
 // For WinDDK ATL compatibility, these ATL headers must come first.
 #include "build/build_config.h"
+
 #if defined(OS_WIN)
 #include <atlbase.h>  // NOLINT
 #include <atlwin.h>  // NOLINT
@@ -12,6 +13,8 @@
 #include "base/macros.h"
 #include "chrome/browser/ui/views/omnibox/omnibox_result_view.h"
 
+#include <limits.h>
+
 #include <algorithm>  // NOLINT
 
 #include "base/i18n/bidi_line_iterator.h"

diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/ui/webui/md_downloads/downloads_list_tracker.h"
 
+#include <limits.h>
 #include <stdint.h>
 
 #include <vector>

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
 
+#include <limits.h>
+
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"

diff --git a/chrome/common/net/x509_certificate_model_openssl.cc b/chrome/common/net/x509_certificate_model_openssl.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/common/net/x509_certificate_model.h"
 
+#include <limits.h>
 #include <openssl/mem.h>
 #include <openssl/obj_mac.h>
 #include <openssl/sha.h>

diff --git a/chrome/common/safe_browsing/protobuf_message_param_traits.h b/chrome/common/safe_browsing/protobuf_message_param_traits.h
@@ -5,6 +5,8 @@
 #ifndef CHROME_COMMON_SAFE_BROWSING_PROTOBUF_MESSAGE_PARAM_TRAITS_H_
 #define CHROME_COMMON_SAFE_BROWSING_PROTOBUF_MESSAGE_PARAM_TRAITS_H_
 
+#include <limits.h>
+
 #include <string>
 
 #include "base/pickle.h"

diff --git a/chrome/test/logging/win/file_logger.cc b/chrome/test/logging/win/file_logger.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/test/logging/win/file_logger.h"
 
+#include <limits.h>
 #include <windows.h>
 #include <guiddef.h>
 #include <objbase.h>

diff --git a/chrome/utility/cloud_print/pwg_encoder.cc b/chrome/utility/cloud_print/pwg_encoder.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/utility/cloud_print/pwg_encoder.h"
 
+#include <limits.h>
 #include <string.h>
 
 #include <algorithm>

diff --git a/chrome/utility/safe_browsing/mac/crdmg.cc b/chrome/utility/safe_browsing/mac/crdmg.cc
@@ -4,6 +4,7 @@
 
 #include <errno.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <sandbox.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/components/crash/content/app/breakpad_mac.mm b/components/crash/content/app/breakpad_mac.mm
@@ -11,7 +11,6 @@
 
 #include "base/auto_reset.h"
 #include "base/base_switches.h"
-#import "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/debug/dump_without_crashing.h"

diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -4,6 +4,7 @@
 
 #include "components/cronet/android/cronet_url_request_context_adapter.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include <map>

diff --git a/components/drive/resource_metadata.cc b/components/drive/resource_metadata.cc
@@ -4,6 +4,7 @@
 
 #include "components/drive/resource_metadata.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include "base/bind.h"

diff --git a/components/mus/public/cpp/tests/window_unittest.cc b/components/mus/public/cpp/tests/window_unittest.cc
@@ -4,6 +4,7 @@
 
 #include "components/mus/public/cpp/window.h"
 
+#include <limits.h>
 #include <stdint.h>
 
 #include "base/logging.h"

diff --git a/components/nacl/renderer/plugin/srpc_client.cc b/components/nacl/renderer/plugin/srpc_client.cc
@@ -6,6 +6,7 @@
 
 #include "components/nacl/renderer/plugin/srpc_client.h"
 
+#include <limits.h>
 #include <stdint.h>
 #include <string.h>
 

diff --git a/components/policy/core/common/schema.cc b/components/policy/core/common/schema.cc
@@ -4,6 +4,7 @@
 
 #include "components/policy/core/common/schema.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include <algorithm>

diff --git a/components/safe_browsing_db/prefix_set.cc b/components/safe_browsing_db/prefix_set.cc
@@ -4,6 +4,8 @@
 
 #include "components/safe_browsing_db/prefix_set.h"
 
+#include <limits.h>
+
 #include <algorithm>
 
 #include "base/files/file_util.h"

diff --git a/components/signin/core/browser/signin_metrics.cc b/components/signin/core/browser/signin_metrics.cc
@@ -4,6 +4,8 @@
 
 #include "components/signin/core/browser/signin_metrics.h"
 
+#include <limits.h>
+
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics.h"

diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h
@@ -7,6 +7,8 @@
 
 #include "base/time/time.h"
 
+#include <limits.h>
+
 #include "google_apis/gaia/google_service_auth_error.h"
 
 namespace signin_metrics {

diff --git a/components/ssl_errors/error_classification.cc b/components/ssl_errors/error_classification.cc
@@ -4,6 +4,7 @@
 
 #include "components/ssl_errors/error_classification.h"
 
+#include <limits.h>
 #include <stddef.h>
 
 #include <vector>

diff --git a/components/variations/metrics_util.cc b/components/variations/metrics_util.cc
@@ -4,6 +4,8 @@
 
 #include "components/variations/metrics_util.h"
 
+#include <string.h>
+
 #include "base/sha1.h"
 #include "base/sys_byteorder.h"
 

diff --git a/components/webcrypto/algorithms/aes_cbc_unittest.cc b/components/webcrypto/algorithms/aes_cbc_unittest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/components/webcrypto/algorithms/hmac_unittest.cc b/components/webcrypto/algorithms/hmac_unittest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/components/webcrypto/webcrypto_impl.cc b/components/webcrypto/webcrypto_impl.cc
@@ -4,6 +4,7 @@
 
 #include "components/webcrypto/webcrypto_impl.h"
 
+#include <limits.h>
 #include <stdint.h>
 
 #include "base/bind.h"

diff --git a/content/plugin/plugin_interpose_util_mac.h b/content/plugin/plugin_interpose_util_mac.h
@@ -5,8 +5,6 @@
 #ifndef CONTENT_PLUGIN_PLUGIN_INTERPOSE_UTIL_MAC_H_
 #define CONTENT_PLUGIN_PLUGIN_INTERPOSE_UTIL_MAC_H_
 
-#import "base/basictypes.h"
-
 namespace mac_plugin_interposing {
 
 // Swizzles methods we need to watch in order to manage process and window

diff --git a/gpu/command_buffer/client/query_tracker.h b/gpu/command_buffer/client/query_tracker.h
@@ -6,6 +6,7 @@
 #define GPU_COMMAND_BUFFER_CLIENT_QUERY_TRACKER_H_
 
 #include <GLES2/gl2.h>
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -4,6 +4,7 @@
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
@@ -4,6 +4,7 @@
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc
@@ -4,6 +4,7 @@
 
 #include "gpu/command_buffer/service/sync_point_manager.h"
 
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 

diff --git a/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc b/gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc
@@ -5,6 +5,8 @@
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <GLES2/gl2extchromium.h>
+#include <stdint.h>
+#include <string.h>
 
 #include "base/command_line.h"
 #include "gpu/command_buffer/service/gpu_switches.h"
@@ -173,7 +175,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, CoverageModulation) {
   }
   static const float kBlue[] = {0.0f, 0.0f, 1.0f, 1.0f};
   static const float kGreen[] = {0.0f, 1.0f, 0.0f, 1.0f};
-  scoped_ptr<uint8[]> results[3];
+  scoped_ptr<uint8_t[]> results[3];
   const GLint kResultSize = kWidth * kHeight * 4;
 
   for (int pass = 0; pass < 3; ++pass) {
@@ -190,7 +192,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, CoverageModulation) {
       glCoverageModulationCHROMIUM(GL_NONE);
     }
 
-    results[pass].reset(new uint8[kResultSize]);
+    results[pass].reset(new uint8_t[kResultSize]);
     memset(results[pass].get(), GLTestHelper::kCheckClearValue, kResultSize);
     glReadPixels(0, 0, kWidth, kHeight, GL_RGBA, GL_UNSIGNED_BYTE,
                  results[pass].get());
@@ -213,7 +215,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, MultisampleStencilEffective) {
   static const float kBlue[] = {0.0f, 0.0f, 1.0f, 1.0f};
   static const float kGreen[] = {0.0f, 1.0f, 0.0f, 1.0f};
 
-  scoped_ptr<uint8[]> results[3];
+  scoped_ptr<uint8_t[]> results[3];
   const GLint kResultSize = kWidth * kHeight * 4;
 
   for (int pass = 0; pass < 3; ++pass) {
@@ -228,7 +230,7 @@ TEST_F(CHROMIUMFramebufferMixedSamplesTest, MultisampleStencilEffective) {
     glUniform4fv(color_loc_, 1, kBlue);
     glDrawArrays(GL_TRIANGLES, 3, 3);
 
-    results[pass].reset(new uint8[kResultSize]);
+    results[pass].reset(new uint8_t[kResultSize]);
     memset(results[pass].get(), GLTestHelper::kCheckClearValue, kResultSize);
     glReadPixels(0, 0, kWidth, kHeight, GL_RGBA, GL_UNSIGNED_BYTE,
                  results[pass].get());