Skip to content

Commit

Permalink
sandbox/linux: Remove basictypes.h includes from services/ directory.
Browse files Browse the repository at this point in the history
Tested on Linux with the following command lines:

$ rm -rf out/
$ ./build/gyp_chromium
$ ninja -C out/Debug sandbox_linux_unittests
$ out/Debug/sandbox_linux_unittests

BUG=138542
TEST=see above
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1093983002

Cr-Commit-Position: refs/heads/master@{#325837}
  • Loading branch information
tfarina authored and Commit bot committed Apr 20, 2015
1 parent e0d1de3 commit 33b6164
Show file tree
Hide file tree
Showing 10 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion sandbox/linux/services/credentials.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@

#include <errno.h>
#include <signal.h>
#include <stdint.h>
#include <stdio.h>
#include <sys/syscall.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>

#include "base/basictypes.h"
#include "base/bind.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
Expand Down
2 changes: 1 addition & 1 deletion sandbox/linux/services/credentials.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#include <string>
#include <vector>

#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "sandbox/linux/system_headers/capability.h"
#include "sandbox/sandbox_export.h"
Expand Down
1 change: 0 additions & 1 deletion sandbox/linux/services/resource_limits.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <sys/resource.h>

#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "sandbox/sandbox_export.h"
Expand Down
1 change: 0 additions & 1 deletion sandbox/linux/services/scoped_process.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <sys/wait.h>
#include <unistd.h>

#include "base/basictypes.h"
#include "base/callback.h"
#include "base/logging.h"
#include "base/posix/eintr_wrapper.h"
Expand Down
2 changes: 1 addition & 1 deletion sandbox/linux/services/scoped_process.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#ifndef SANDBOX_LINUX_SERVICES_SCOPED_PROCESS_H_
#define SANDBOX_LINUX_SERVICES_SCOPED_PROCESS_H_

#include "base/basictypes.h"
#include "base/callback_forward.h"
#include "base/macros.h"
#include "base/process/process_handle.h"
#include "sandbox/sandbox_export.h"

Expand Down
4 changes: 2 additions & 2 deletions sandbox/linux/services/scoped_process_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "sandbox/linux/services/scoped_process.h"

#include <errno.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>

#include "base/basictypes.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/files/file_util.h"
Expand All @@ -18,7 +19,6 @@
#include "base/posix/eintr_wrapper.h"
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "sandbox/linux/services/scoped_process.h"
#include "sandbox/linux/tests/unit_tests.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion sandbox/linux/services/thread_helpers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

#include <string>

#include "base/basictypes.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/files/scoped_file.h"
Expand Down
2 changes: 1 addition & 1 deletion sandbox/linux/services/thread_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef SANDBOX_LINUX_SERVICES_THREAD_HELPERS_H_
#define SANDBOX_LINUX_SERVICES_THREAD_HELPERS_H_

#include "base/basictypes.h"
#include "base/macros.h"
#include "sandbox/sandbox_export.h"

namespace base { class Thread; }
Expand Down
1 change: 0 additions & 1 deletion sandbox/linux/services/thread_helpers_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <sys/types.h>
#include <unistd.h>

#include "base/basictypes.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/posix/eintr_wrapper.h"
Expand Down
3 changes: 1 addition & 2 deletions sandbox/linux/services/yama.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
#ifndef SANDBOX_LINUX_SERVICES_YAMA_H_
#define SANDBOX_LINUX_SERVICES_YAMA_H_

#include "base/basictypes.h"
#include "base/process/process_handle.h"
#include "base/macros.h"
#include "sandbox/sandbox_export.h"

namespace sandbox {
Expand Down

0 comments on commit 33b6164

Please sign in to comment.