Add support for asset creation

Added coresponding unit test for PHP 5.3.4 or newer. SSL extensions are not fully working for 5.3.3. See travis-ci/travis-ci#1385.

Updated documentation to show that Asset creation is now supported.

Author: kasperg

doc/repo/assets.md

@@ -15,7 +15,9 @@ $asset = $client->api('repo')->releases()->assets()->show('twbs', 'bootstrap', $
 
 ### Create an asset
 
-This feature is not implemented because require usage of `uploads.github.com` subdomain.
+```php
+$asset = $client->api('repo')->releases()->assets()->show('twbs', 'bootstrap', $releaseId, $name, $contentType, $content);
+```
 
 ### Edit an asset
 

lib/Github/Api/AbstractApi.php

@@ -169,10 +169,11 @@ protected function delete($path, array $parameters = array(), $requestHeaders =
     /**
      * Create a JSON encoded version of an array of parameters.
      *
-     * @param $parameters   Request parameters
+     * @param array $parameters   Request parameters
      * @return null|string
      */
-    protected function createJsonBody(array $parameters) {
+    protected function createJsonBody(array $parameters)
+    {
         return (count($parameters) === 0) ? null : json_encode($parameters, empty($parameters) ? JSON_FORCE_OBJECT : 0);
     }
 }

lib/Github/Api/Repository/Assets.php

@@ -3,7 +3,9 @@
 namespace Github\Api\Repository;
 
 use Github\Api\AbstractApi;
+use Github\Exception\ErrorException;
 use Github\Exception\MissingArgumentException;
+use Github\HttpClient\HttpClient;
 
 /**
  * @link   http://developer.github.com/v3/repos/releases/
@@ -41,6 +43,47 @@ public function show($username, $repository, $id)
         return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/releases/assets/'.rawurlencode($id));
     }
 
+    /**
+     * Create an asset for selected repository's release
+     * POST /repos/:owner/:repo/releases/:id/assets?name=:filename
+     *
+     * Creating an asset requires support for server name indentification (SNI)
+     * so this must be supported by your PHP version.
+     * @see http://developer.github.com/v3/repos/releases/#upload-a-release-asset
+     * @see http://php.net/manual/en/openssl.constsni.php
+     *
+     * @param  string $username the user who owns the repo
+     * @param  string $repository the name of the repo
+     * @param  integer $id the id of the release
+     * @param  string $name the filename for the asset
+     * @param  string $contentType the content type for the asset
+     * @param  string $content the content of the asset
+     *
+     * @throws MissingArgumentException
+     * @throws ErrorException
+     *
+     * @return array
+     */
+    public function create($username, $repository, $id, $name, $contentType, $content)
+    {
+        if (!defined('OPENSSL_TLSEXT_SERVER_NAME') || !OPENSSL_TLSEXT_SERVER_NAME) {
+            throw new ErrorException('Asset upload support requires Server Name Indication. This is not supported se your PHP version. See http://php.net/manual/en/openssl.constsni.php.');
+        }
+
+        // Asset creation requires a separate endpoint, uploads.github.com.
+        // Change the base url for the HTTP client temporarily while we execute
+        // this request.
+        $baseUrl = $this->client->getHttpClient()->client->getBaseUrl();
+        $this->client->getHttpClient()->client->setBaseUrl('https://uploads.github.com/');
+
+        $response = $this->postRaw('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/releases/'.rawurlencode($id).'/assets?name='.$name, $content, array('Content-Type' => $contentType));
+
+        // Reset the base url.
+        $this->client->getHttpClient()->client->setBaseUrl($baseUrl);
+
+        return $response;
+    }
+
     /**
      * Edit an asset in selected repository's release
      * PATCH /repos/:owner/:repo/releases/assets/:id

test/Github/Tests/Api/Repository/AssetsTest.php

@@ -40,6 +40,26 @@ public function shouldGetSingleReleaseAsset()
         $this->assertEquals($expectedValue, $api->show('KnpLabs', 'php-github-api', $assetId));
     }
 
+    /**
+     * @test
+     * @requires PHP 5.3.4
+     */
+    public function shouldCreateReleaseAsset()
+    {
+        $name = 'asset.gzip';
+        $body = 'assetCreatedData';
+        $contentType = 'application/gzip';
+        $releaseId = '12345';
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+          ->method('postRaw')
+          ->with('repos/KnpLabs/php-github-api/releases/'. $releaseId .'/assets?name='.$name)
+          ->will($this->returnValue($body));
+
+        $this->assertEquals($body, $api->create('KnpLabs', 'php-github-api', $releaseId, $name, $contentType, $body));
+    }
+
     /**
      * @test
      */