From 41058c8e627edaaf8bf6132d106e01fd81c2ef7d Mon Sep 17 00:00:00 2001 From: ikarlashov Date: Sun, 9 Feb 2025 10:26:15 +0100 Subject: [PATCH] chore!: remove declaration of unused variables for docker-autoscaler setup (#1223) # Description This PR removes the declaration of some settings of `var.runner_worker_docker_autoscaler_asg` that are never used in the terraform manifests of the module. --------- Signed-off-by: Yevgen Karlashov Co-authored-by: Matthias Kay --- examples/runner-fleeting-plugin/main.tf | 1 - variables.tf | 5 ----- 2 files changed, 6 deletions(-) diff --git a/examples/runner-fleeting-plugin/main.tf b/examples/runner-fleeting-plugin/main.tf index 59480428..b7f3a089 100644 --- a/examples/runner-fleeting-plugin/main.tf +++ b/examples/runner-fleeting-plugin/main.tf @@ -104,7 +104,6 @@ module "runner" { enable_mixed_instances_policy = true on_demand_base_capacity = 1 on_demand_percentage_above_base_capacity = 0 - max_growth_rate = 10 } runner_worker_docker_autoscaler_autoscaling_options = [ diff --git a/variables.tf b/variables.tf index 85ef9526..3092ce92 100644 --- a/variables.tf +++ b/variables.tf @@ -731,11 +731,8 @@ variable "runner_worker_docker_autoscaler_asg" { health_check_type = Controls how health checking is done. Values are - EC2 and ELB. instance_refresh_min_healthy_percentage = The amount of capacity in the Auto Scaling group that must remain healthy during an instance refresh to allow the operation to continue, as a percentage of the desired capacity of the Auto Scaling group. instance_refresh_triggers = Set of additional property names that will trigger an Instance Refresh. A refresh will always be triggered by a change in any of launch_configuration, launch_template, or mixed_instances_policy. - max_growth_rate = The maximum number of machines that can be added to the runner in parallel. on_demand_base_capacity = Absolute minimum amount of desired capacity that must be fulfilled by on-demand instances. on_demand_percentage_above_base_capacity = Percentage split between on-demand and Spot instances above the base on-demand capacity. - override_instance_types = List to override the instance type in the Launch Template. Allow to spread spot instances on several types, to reduce interruptions. - profile_name = profile_name = Name of the IAM profile to attach to the Runner Workers. spot_allocation_strategy = How to allocate capacity across the Spot pools. 'lowest-price' to optimize cost, 'capacity-optimized' to reduce interruptions. spot_instance_pools = Number of Spot pools per availability zone to allocate capacity. EC2 Auto Scaling selects the cheapest Spot pools and evenly allocates Spot capacity across the number of Spot pools that you specify. subnet_ids = The list of subnet IDs to use for the Runner Worker when the fleet mode is enabled. @@ -749,10 +746,8 @@ variable "runner_worker_docker_autoscaler_asg" { health_check_type = optional(string, "EC2") instance_refresh_min_healthy_percentage = optional(number, 90) instance_refresh_triggers = optional(list(string), []) - max_growth_rate = optional(number, 0) on_demand_base_capacity = optional(number, 0) on_demand_percentage_above_base_capacity = optional(number, 100) - profile_name = optional(string, "") spot_allocation_strategy = optional(string, "lowest-price") spot_instance_pools = optional(number, 2) subnet_ids = optional(list(string), [])