Checkstyle and doc link problems

Author: drcgjung

core/common/boot/src/main/java/org/eclipse/dataspaceconnector/boot/system/injection/lifecycle/ExtensionLifecycleManager.java

@@ -25,9 +25,9 @@
  * {@link ServiceExtension} implementors should not be constructed by just invoking their constructors, instead they need to go through
  * a lifecycle, which is what this class aims at doing. There are three major phases for initialization:
  * <ol>
- *     <li>inject dependencies: all fields annotated with {@link org.eclipse.dataspaceconnector.spi.system.Inject} are set</li>
+ *     <li>inject dependencies: all fields annotated with {@link org.eclipse.dataspaceconnector.runtime.metamodel.annotation.Inject} are set</li>
  *     <li>initialize: invokes the {@link ServiceExtension#initialize(ServiceExtensionContext)} method</li>
- *     <li>provide: invokes all methods annotated with {@link org.eclipse.dataspaceconnector.spi.system.Provider} to register more services into the context</li>
+ *     <li>provide: invokes all methods annotated with {@link org.eclipse.dataspaceconnector.runtime.metamodel.annotation.Provider} to register more services into the context</li>
  * </ol>
  * <p>
  * The sequence of these phases is actually important.
@@ -62,7 +62,7 @@ public static RegistrationPhase initialize(InitializePhase phase) {
     }
 
     /**
-     * Scans the {@linkplain ServiceExtension} for methods annotated with {@linkplain org.eclipse.dataspaceconnector.spi.system.Provider}
+     * Scans the {@linkplain ServiceExtension} for methods annotated with {@linkplain org.eclipse.dataspaceconnector.runtime.metamodel.annotation.Provider}
      * with the {@link Provider#isDefault()} flag set to {@code false}, invokes them and registers the bean into the {@link ServiceExtensionContext} if necessary.
      */
     public static PreparePhase provide(RegistrationPhase phase) {

core/control-plane/contract/src/main/java/org/eclipse/dataspaceconnector/contract/negotiation/ConsumerContractNegotiationManagerImpl.java

@@ -361,7 +361,7 @@ private boolean processConsumerApproving(ContractNegotiation negotiation) {
 
         var policy = lastOffer.getPolicy();
         var agreement = ContractAgreement.Builder.newInstance()
-                .id(ContractId.createContractId(definitionId,lastOffer.getAsset().getId()))
+                .id(ContractId.createContractId(definitionId, lastOffer.getAsset().getId()))
                 .contractStartDate(clock.instant().getEpochSecond())
                 .contractEndDate(clock.instant().plus(365, ChronoUnit.DAYS).getEpochSecond()) // TODO Make configurable (issue #722)
                 .contractSigningDate(clock.instant().getEpochSecond())

core/control-plane/contract/src/main/java/org/eclipse/dataspaceconnector/contract/negotiation/ProviderContractNegotiationManagerImpl.java

@@ -351,7 +351,7 @@ private boolean processConfirming(ContractNegotiation negotiation) {
             policy = lastOffer.getPolicy();
             //TODO move to own service
             agreement = ContractAgreement.Builder.newInstance()
-                    .id(ContractId.createContractId(definitionId,lastOffer.getAsset().getId()))
+                    .id(ContractId.createContractId(definitionId, lastOffer.getAsset().getId()))
                     .contractStartDate(clock.instant().getEpochSecond())
                     .contractEndDate(clock.instant().plus(365, ChronoUnit.DAYS).getEpochSecond()) // TODO Make configurable (issue #722)
                     .contractSigningDate(clock.instant().getEpochSecond())

core/control-plane/contract/src/main/java/org/eclipse/dataspaceconnector/contract/offer/ContractOfferServiceImpl.java

@@ -33,9 +33,9 @@
 
 import java.net.URI;
 import java.util.Optional;
+import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
-import java.util.regex.Pattern;
 
 /**
  * Implementation of the {@link ContractOfferService}.
@@ -67,10 +67,10 @@ public Stream<ContractOffer> queryContractOffers(ContractOfferQuery query, Range
                             .map(policyStore::findById)
                             .map(policy -> {
                                 // check policy target for compliance with the asset id
-                                final Pattern targetPattern=policy.getPolicy().getTarget()!=null ?
+                                final Pattern targetPattern = policy.getPolicy().getTarget() != null ?
                                         Pattern.compile(policy.getPolicy().getTarget()) : null;
                                 return assets.flatMap(asset -> {
-                                    if(targetPattern==null || targetPattern.matcher(asset.getId()).matches()) {
+                                    if (targetPattern == null || targetPattern.matcher(asset.getId()).matches()) {
                                         return Stream.of(createContractOffer(definition, policy.getPolicy(), asset));
                                     } else {
                                         return Stream.empty();
@@ -84,7 +84,7 @@ public Stream<ContractOffer> queryContractOffers(ContractOfferQuery query, Range
     @NotNull
     private ContractOffer createContractOffer(ContractDefinition definition, Policy policy, Asset asset) {
         return ContractOffer.Builder.newInstance()
-                .id(ContractId.createContractId(definition.getId(),asset.getId()))
+                .id(ContractId.createContractId(definition.getId(), asset.getId()))
                 .policy(policy.withTarget(asset.getId()))
                 .asset(asset)
                 // TODO: this is a workaround for the bug described in https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/issues/753