switch block_hash_history_test tests to TraitsTest #1829
+364
−302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the block hash history tests to use a parameterized TraitsTest pattern, enabling tests to run across multiple EVM revision types (both Monad and standard EVM revisions) instead of being hardcoded to Prague.
Key Changes:
- Extracted the test fixture and helper methods into a reusable header file
- Converted specific tests from
TEST_FtoTYPED_TESTto support multiple EVM revisions - Added revision-specific conditional logic to skip tests for pre-Prague revisions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| block_hash_history_traits_test.hpp | New header file containing base test fixture and parameterized trait-based test fixture for block hash history tests |
| block_hash_history_test.cpp | Refactored to use the new trait-based test fixtures, converting Prague-specific tests to typed tests that work across revisions |
| CMakeLists.txt | Added the new header file to the build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goodlyrottenapple
force-pushed
the
sam/traits_test_block_hash_history_test
branch
4 times, most recently
from
d95dcba to
773181c
Compare
goodlyrottenapple
force-pushed
the
sam/traits_test_block_hash_history_test
branch
from
773181c to
43c659d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.