-
Couldn't load subscription status.
- Fork 374
minor run loop refactoring #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c5aee8a to
69de864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the block processing logic to improve the ordering of operations and optimize cache entry management. The key change moves block cache insertion earlier in the execution flow, allowing senders and authorities to be populated directly into the cached entry rather than using a temporary set.
- Moved block cache insertion before sender/authority collection in
runloop_monad.cpp - Refactored
process_ethereum_blockto return the output header instead of computing the block hash internally - Added compile-time size and alignment assertions for
MonadChainContext
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/monad/runloop_monad.cpp | Reordered block cache insertion and validation; eliminated temporary senders_and_authorities set |
| cmd/monad/runloop_ethereum.cpp | Changed return type to BlockHeader; moved block hash computation to caller |
| category/execution/monad/chain/monad_chain.hpp | Added static assertions for MonadChainContext size and alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot cleaner
69de864 to
da8c92e
Compare
No description provided.