Skip to content

Conversation

@zander-xyz
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the block processing logic to improve the ordering of operations and optimize cache entry management. The key change moves block cache insertion earlier in the execution flow, allowing senders and authorities to be populated directly into the cached entry rather than using a temporary set.

  • Moved block cache insertion before sender/authority collection in runloop_monad.cpp
  • Refactored process_ethereum_block to return the output header instead of computing the block hash internally
  • Added compile-time size and alignment assertions for MonadChainContext

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
cmd/monad/runloop_monad.cpp Reordered block cache insertion and validation; eliminated temporary senders_and_authorities set
cmd/monad/runloop_ethereum.cpp Changed return type to BlockHeader; moved block hash computation to caller
category/execution/monad/chain/monad_chain.hpp Added static assertions for MonadChainContext size and alignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zander-xyz zander-xyz changed the title Alee/runloop minor run loop refactoring Oct 23, 2025
@zander-xyz zander-xyz marked this pull request as ready for review October 23, 2025 18:02
Copy link
Contributor

@kjcamann kjcamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants