Add more metrics for account/storage touched/changed

Author: Akatsukis

category/execution/ethereum/db/db_cache.hpp

@@ -68,6 +68,10 @@ class DbCache final : public Db
     AccountsCache accounts_{10'000'000};
     StorageCache storage_{10'000'000};
     Proposals proposals_;
+    size_t account_touched_{0};
+    size_t account_changed_{0};
+    size_t storage_touched_{0};
+    size_t storage_changed_{0};
 
 public:
     DbCache(Db &db)
@@ -216,26 +220,46 @@ class DbCache final : public Db
     virtual std::string print_stats() override
     {
         return db_.print_stats() + ",ac=" + accounts_.print_stats() +
-               ",sc=" + storage_.print_stats();
+               ",sc=" + storage_.print_stats() + print_read_write_stats();
     }
 
     virtual uint64_t get_block_number() const override
     {
         return db_.get_block_number();
     }
 
+    std::string print_read_write_stats() const
+    {
+        return ",at=" + std::to_string(account_touched_) +
+               ",am=" + std::to_string(account_changed_) +
+               ",st=" + std::to_string(storage_touched_) +
+               ",sm=" + std::to_string(storage_changed_);
+    }
+
 private:
     void insert_in_lru_caches(StateDeltas const &state_deltas)
     {
+        account_touched_ = 0;
+        account_changed_ = 0;
+        storage_touched_ = 0;
+        storage_changed_ = 0;
         for (auto it = state_deltas.cbegin(); it != state_deltas.cend(); ++it) {
             auto const &address = it->first;
             auto const &account_delta = it->second.account;
             accounts_.insert(address, account_delta.second);
             auto const &storage = it->second.storage;
             auto const &account = account_delta.second;
             if (account.has_value()) {
+                ++account_touched_;
+                if (account_delta.first != account_delta.second) {
+                    ++account_changed_;
+                }
                 for (auto it2 = storage.cbegin(); it2 != storage.cend();
                      ++it2) {
+                    ++storage_touched_;
+                    if (it2->second.first != it2->second.second) {
+                        ++storage_changed_;
+                    }
                     auto const &key = it2->first;
                     auto const &storage_delta = it2->second;
                     auto const incarnation = account->incarnation;

category/execution/ethereum/metrics/block_metrics.hpp

@@ -46,6 +46,7 @@ class BlockMetrics
     {
         return tx_exec_time_;
     }
+
 };
 
 MONAD_NAMESPACE_END

cmd/monad/runloop_ethereum.cpp

@@ -85,7 +85,7 @@ Result<void> process_ethereum_block(
     fiber::PriorityPool &priority_pool, Block &block, bytes32_t const &block_id,
     bytes32_t const &parent_block_id, bool const enable_tracing)
 {
-    [[maybe_unused]] auto const block_start = std::chrono::system_clock::now();
+    [[maybe_unused]] auto const block_start = std::chrono::steady_clock::now();
     auto const block_begin = std::chrono::steady_clock::now();
 
     // Block input validation

cmd/monad/runloop_monad.cpp

@@ -155,7 +155,7 @@ Result<BlockExecOutput> propose_block(
     vm::VM &vm, fiber::PriorityPool &priority_pool, bool const is_first_block,
     bool const enable_tracing, BlockCache &block_cache)
 {
-    [[maybe_unused]] auto const block_start = std::chrono::system_clock::now();
+    [[maybe_unused]] auto const block_start = std::chrono::steady_clock::now();
     auto const block_begin = std::chrono::steady_clock::now();
     auto const &block_hash_buffer =
         block_hash_chain.find_chain(consensus_header.parent_id());