Apply Yaml pre-commit formatter

[bendnorman]

Folks have different YAML formatters in our code editors so we need a pre-commit hook to do the formatting for us!

[bendnorman]

Doesn't seem like there are any yaml formatting pre-commit hooks that are amenable to our current yaml formatting. I found three options:

• yamlfix: Opinionated formatted that can't be configured.
• yamlfmt: Formatterr than can be configured but I couldn't figure out options to recreate our current formatting.

@zaneselvans what yaml formatter are you using?

[zaneselvans]

I've been doing the formatting by hand, but then occasionally VS Code or gvim seems to have strong opinions about indentation. It looks like with yamlfix we have the option of lists being condensed (if we use [x, y, z] or having a single element per line if we use the - to indicate each one. I don't totally love it but at least it would be guaranteed to be uniform for everyone which is the most important thing.

[zaneselvans]

Poking around to try and find a way to integrate yamlfix into VS Code I found this extension from RedHat which lints and autoformats, and also checks the YAML against published schemas if they can be detected, which seems like it would be nice. I wonder if we can make it format along the lines of yamlfix.

[zaneselvans]

Not totally sure what the conflict is in the pre-config settings because the whole file was re-written.

[bendnorman]

https://prettier.io/ is also an option. It offers a pre-commit and a vscode extension but it can't be configured like the red hat extension. The Red Hat extension doesn't offer a pre-commit or command-line tool.

[bendnorman]

Ooo I like prettier:

• It retains our - formatting for the settings files.
• It's by far the most established YAML formatter I've found (42k stars).
• Has a popular VSCode extension.

One con is that it puts each year on its own line in the settings files.

[zaneselvans]

Widespread support seems like a strong reason to use it.

It seems like it's putting years on individual lines sometimes but not others and I'm not sure why.

I'm fine with whatever you choose! The most important thing is we can have something standardized and well supported.

[bendnorman]

Changes:

• Add prettier pre-commit hook for consistent YAML formatting.