-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: change executable name into "cataclysm-bn-tiles" #4989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check all cataclysm
and cataclysm-bn
is changed accordingly?
Co-authored-by: scarf <greenscarf005@gmail.com>
go to discord settings>registered games>add game |
Discord manually sets up every connection for the user on their end (Which I am still livid about, you can't change it once they do it) They will not create the connection unless someone emails them about it or gets in contact with someone directly. |
Nice, that seems fine to me then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see how it turns out...
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
doc/
folder.Purpose of change
Apps detecting games, such as Discord considers this game as Cataclysm DDA as they both has same exe name. So i added -bn to this fork, giving a way to differ.
Describe the solution
Replaced cataclysm-tiles with cataclysm-bn-tiles and replaced cataclysm on cmake files with cataclysm-bn.
Describe alternatives you've considered
Look deeply on game detecting apps and make them recognize CBN by just from window name, not the executable one.
Testing
MSYS2 tiled version showed bn name both on console and task manager. Additional OS and curses tests are welcome.
Additional context
Should help with #3497.
Discord saying it gets game data from https://www.igdb.com/ , as Discord-recognized CDDA has its own page on it: https://www.igdb.com/games/cataclysm-dark-days-ahead .
We need to do some off site work for recognition.