Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change executable name into "cataclysm-bn-tiles" #4989

Merged
merged 18 commits into from
Jul 15, 2024

Conversation

Ali-Anomma
Copy link
Contributor

Checklist

Required

Optional

  • This is a PR that modifies build process or code organization.
    • Please document the changes in the appropriate location in the doc/ folder.

Purpose of change

Apps detecting games, such as Discord considers this game as Cataclysm DDA as they both has same exe name. So i added -bn to this fork, giving a way to differ.

Describe the solution

Replaced cataclysm-tiles with cataclysm-bn-tiles and replaced cataclysm on cmake files with cataclysm-bn.

Describe alternatives you've considered

Look deeply on game detecting apps and make them recognize CBN by just from window name, not the executable one.

Testing

MSYS2 tiled version showed bn name both on console and task manager. Additional OS and curses tests are welcome.

Additional context

Should help with #3497.
Discord saying it gets game data from https://www.igdb.com/ , as Discord-recognized CDDA has its own page on it: https://www.igdb.com/games/cataclysm-dark-days-ahead .
We need to do some off site work for recognition.

@github-actions github-actions bot added docs PRs releated to docs page src changes related to source code. tests changes related to tests scripts related to game management scripts labels Jul 13, 2024
chaosvolt
chaosvolt previously approved these changes Jul 14, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Compiled and load-tested.
  2. Discord no longer has it pop up as anything.

image

I assume that's an improvement at least over it mislabeling us as DDA.

@scarf005 scarf005 changed the title chore(UI): change executable name into "cataclysm-bn-tiles" build: change executable name into "cataclysm-bn-tiles" Jul 14, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check all cataclysm and cataclysm-bn is changed accordingly?

cataclysm-launcher Outdated Show resolved Hide resolved
Co-authored-by: scarf <greenscarf005@gmail.com>
@Ali-Anomma
Copy link
Contributor Author

  1. Compiled and load-tested.
  2. Discord no longer has it pop up as anything.

image

I assume that's an improvement at least over it mislabeling us as DDA.

go to discord settings>registered games>add game
there is something named with random numbers and letters (name of CBN instance after cataclysm bright nights part). select it.
igbd registeration needed for universal "Cataclysm: Bright Nights" text for everyone

@RoyalFox2140
Copy link
Collaborator

  1. Compiled and load-tested.
  2. Discord no longer has it pop up as anything.

image

I assume that's an improvement at least over it mislabeling us as DDA.

Discord manually sets up every connection for the user on their end (Which I am still livid about, you can't change it once they do it) They will not create the connection unless someone emails them about it or gets in contact with someone directly.

@chaosvolt
Copy link
Member

Nice, that seems fine to me then.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see how it turns out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page scripts related to game management scripts src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants