Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed odd mapgen in house basement #3344

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

Vollch
Copy link
Contributor

@Vollch Vollch commented Oct 2, 2023

Summary

SUMMARY: Bugfixes "Fixed odd mapgen in house basement"

Purpose of change

Fixes #1365. And also patched small hole in mansion roof along the way.

Describe the solution

Opened save attached to bug report, checked debug map to see what oter it is(house_modern_1_basement_west), fixed json.

Describe alternatives you've considered

Testing

Regenerated a bunch of house_modern_1_basement_* via debug.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 2, 2023
@Vollch
Copy link
Contributor Author

Vollch commented Oct 2, 2023

Uhm, why autofix ranting about external_tileset.md? I'm not touching it at all.

chaosvolt
chaosvolt previously approved these changes Oct 2, 2023
@chaosvolt chaosvolt dismissed their stale review October 2, 2023 03:26

wait a tic

@chaosvolt
Copy link
Member

Dafuq @scarf005 why does this keep showing up in PRs. >:V

@Vollch
Copy link
Contributor Author

Vollch commented Oct 2, 2023

Hmm. Rebased commit to current HEAD and force-pushed it, still ranting -_-

@chaosvolt
Copy link
Member

Go home autofix.ci you're drunk.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swear on yer fuckin' yeezys autofix bot best stop with this. :V

@chaosvolt chaosvolt added this pull request to the merge queue Oct 2, 2023
Merged via the queue into cataclysmbnteam:upload with commit 8b4336b Oct 2, 2023
olanti-p pushed a commit to olanti-p/Cataclysm-BN that referenced this pull request Oct 6, 2023
* Fixed mapgen of house basement and mansion roof

* style(autofix.ci): automated formatting

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Vollch Vollch deleted the mapgenjson branch October 22, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd basement generation
2 participants