Add a construction to convert street lights to use local power #3273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add a construction entry for converting street lights to use local grid power as a lighting option"
Purpose of change
This adds what was going to be the highlight (heh) of #3265 before the sheer number of locations to give street lights to quickly became two PRs (one still yet to be written) worth of work alone.
Describe the solution
As I found out, for some reason it doesn't work right if it inherits from normal street lights, but making it inherit from
f_floor_lamp_base
while overriding basically all the properties the abstract defines which should thus be the same net effect? That's fine somehow, fucking weird.My guess is because street lights are in furniture-terrains.json and might thus count as a later file in the load order, a rare case of load order being more fiddly than normal.
Describe alternatives you've considered
Testing
Additional context
Lamp off, daytime:
Lamp on, nighttime: