Fix messages involving NPC suffering #2008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix some suffer and bionic messages acting like the player is receiving effects applied to NPCs"
Purpose of change
Was reminded recently that there's a good chunk of messages in the code that tell the player something is happening to them when it's actually happening to an NPC instead.
Describe the solution
add_msg_player_or_npc
so that the player will be alerted if an NPC passes out due to it, instead of printing the same message as if the player passes out.add_msg_if_player
so NPCs with Psychosis won't secretly gaslight the player.add_msg
incorrectly, plus in one case converted a use ofadd_msg_if_player
withadd_msg_player_or_npc
since it has effects the player would see.add_msg_if_player
instead ofadd_msg
.Describe alternatives you've considered
Screaming.
Testing
Additional context