Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompiled header and unity build support for Cmake #1937

Merged
merged 9 commits into from
Oct 15, 2022
Merged

precompiled header and unity build support for Cmake #1937

merged 9 commits into from
Oct 15, 2022

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 2, 2022 •
edited
Loading

Summary

SUMMARY: Build "precompiled header and unity build support for Cmake"

Purpose of change

  • cmake lacks PCH
  • insert warning in COMPILING.md to check SDL2 version before compiling

Describe the solution

Describe alternatives you've considered

Testing

  • not sure how to run tests properly in Cmake, fails with LastTest.log

Additional context

olanti-p
olanti-p reviewed Oct 2, 2022
View reviewed changes
doc/COMPILING/COMPILING.md Outdated Show resolved Hide resolved
@Coolthulhu Coolthulhu self-assigned this Oct 5, 2022
@Coolthulhu Coolthulhu merged commit 5bdea27 into cataclysmbnteam:upload Oct 15, 2022
@scarf005 scarf005 deleted the cmake-pch branch October 25, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olanti-p olanti-p olanti-p left review comments

Assignees

@Coolthulhu Coolthulhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarf005 @olanti-p @Coolthulhu