Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing LuceneSearcher relies on FAISS and Torch #1375

Closed
cakiki opened this issue Dec 7, 2022 · 2 comments
Closed

Importing LuceneSearcher relies on FAISS and Torch #1375

cakiki opened this issue Dec 7, 2022 · 2 comments

Comments

@cakiki
Copy link

cakiki commented Dec 7, 2022

Currently, importing LuceneSearcher fails if faiss and torch aren't installed. (They aren't installed by design because they're platform-specific, see: https://github.com/castorini/pyserini#installation)

This is likely caused by the imports in the following init file: https://github.com/castorini/pyserini/blob/master/pyserini/search/__init__.py#L23-L26

A fix would need to modularize those imports.

If no one gets to it before me, I will attempt to send a PR to fix this.
@MXueguang
Copy link
Member

yeah, PR is welcomed!

@ToluClassics ToluClassics mentioned this issue Dec 16, 2022
Closed
@lintool
Copy link
Member

lintool commented Oct 15, 2024

See #2009 - this has been resolved by #1997

@lintool lintool closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lintool @cakiki @MXueguang