Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duoBERT #15

Open
ronakice opened this issue Apr 29, 2020 · 4 comments
Open

Add duoBERT #15

ronakice opened this issue Apr 29, 2020 · 4 comments
Assignees

Comments

@ronakice
Copy link
Member

ronakice commented Apr 29, 2020

I was looking into adding duo support (k-way ranking potentially) for MSMARCO and TREC-CAR.

For RelevanceExample, I was wondering if we can have documents as Union(List[Text], List[List[Text]]) instead of just List[Text]. I could also do something like this in the evaluate method in RerankerEvaluator. Another way is to add an is_duo argument to the various reranks/class.

Thoughts? @daemon @rodrigonogueira4

@ronakice ronakice self-assigned this Apr 29, 2020
@rodrigonogueira4
Copy link
Member

Yeah, that sounds good to me! For now, I would worry only about duo and forget about the general case as we don't even know how to make it computationally viable

@ronakice
Copy link
Member Author

@wiltan-uw is on this!

@lintool
Copy link
Member

lintool commented Nov 22, 2020

I'm wondering what the relationships between this issue and this repo is: https://github.com/castorini/duobert

Are we planning on deprecating the duobert repo, i.e., but into archive real-only mode?

@rodrigonogueira4
Copy link
Member

Yeah, I think archiving duobert repo is a good idea. It is in tensorflow, and it requires some manual steps to do reranking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants