Get rid of extra options for HNSW indexes #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
============================================
+ Coverage 67.09% 67.11% +0.01%
- Complexity 1472 1473 +1
============================================
Files 219 219
Lines 12628 12628
Branches 1526 1526
============================================
+ Hits 8473 8475 +2
+ Misses 3628 3627 -1
+ Partials 527 526 -1 ☔ View full report in Codecov by Sentry. |
tteofili
approved these changes
Jun 18, 2024
lintool
added a commit
that referenced
this pull request
Jun 24, 2024
HNSW regressions for MS MARCO regressions: revert to "default settings" Continuation of #2531 (which was for BEIR) Will need to adjust score tolerance, but will circle back in a separate PR for that.
Panizghi
pushed a commit
to Panizghi/anserini
that referenced
this pull request
Jul 9, 2024
Removed -memoryBuffer 65536 -noMerge options for HNSW regressions: revert to "default settings".
Panizghi
pushed a commit
to Panizghi/anserini
that referenced
this pull request
Jul 9, 2024
HNSW regressions for MS MARCO regressions: revert to "default settings" Continuation of castorini#2531 (which was for BEIR) Will need to adjust score tolerance, but will circle back in a separate PR for that.
lintool
added a commit
that referenced
this pull request
Sep 19, 2024
+ Wrapped up #2531 - revert to "default settings" for dense indexing - previously was applied for some configs, but not others. This PR makes indexing options consistent across all configs. + Tolerance values are now stored directly in the yaml configs, not centralized in run_regression.py + Changed MS MARCO v1 passage Cohere regressions to use same metrics as other regressions. + Updated topics - removed extra queries for BGE BEIR BioASQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
-memoryBuffer 65536 -noMergeoptions for HNSW regressions: revert to "default settings".