Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MS MARCO regressions into consistent schema #2519

Merged
merged 9 commits into from
Jun 8, 2024
Merged

Conversation

lintool
Copy link
Member

@lintool lintool commented Jun 4, 2024

Consistent naming of indexes, run conditions, etc.

@lintool lintool marked this pull request as draft June 4, 2024 19:24
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.09%. Comparing base (d11e01d) to head (b2300fa).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2519   +/-   ##
=========================================
  Coverage     67.09%   67.09%           
  Complexity     1472     1472           
=========================================
  Files           219      219           
  Lines         12628    12628           
  Branches       1526     1526           
=========================================
  Hits           8473     8473           
  Misses         3628     3628           
  Partials        527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool requested review from tteofili and MXueguang June 8, 2024 10:29
@lintool lintool marked this pull request as ready for review June 8, 2024 10:29
@lintool lintool changed the title Rename MS MARCO regressions into consistent schema. Rename MS MARCO regressions into consistent schema Jun 8, 2024
Copy link
Collaborator

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lintool lintool merged commit 59330e3 into master Jun 8, 2024
3 checks passed
@lintool lintool deleted the msmarco-renaming branch June 8, 2024 12:47
Panizghi pushed a commit to Panizghi/anserini that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants