Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appassembler-maven-plugin #2444

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Remove appassembler-maven-plugin #2444

merged 3 commits into from
Apr 8, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented Apr 6, 2024

Deprecation in JDK 21 of plugin requires an entirely new approach to launch classes.

[WARNING] 
[WARNING] Plugin validation issues were detected in 3 plugin(s)
[WARNING] 
[WARNING]  * org.apache.maven.plugins:maven-javadoc-plugin:3.6.3
[WARNING]  * com.github.eirslett:frontend-maven-plugin:1.12.1
[WARNING]  * org.codehaus.mojo:appassembler-maven-plugin:2.1.0
[WARNING] 
[WARNING] For more or less details, use 'maven.plugin.validation' property with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
[WARNING] 

@lintool lintool marked this pull request as draft April 6, 2024 18:02
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (c0f4347) to head (e6a94f7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2444   +/-   ##
=========================================
  Coverage     66.68%   66.68%           
  Complexity     1417     1417           
=========================================
  Files           213      213           
  Lines         12169    12169           
  Branches       1488     1488           
=========================================
  Hits           8115     8115           
  Misses         3539     3539           
  Partials        515      515           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool marked this pull request as ready for review April 7, 2024 20:25
@lintool lintool requested a review from MXueguang April 7, 2024 20:25
@lintool
Copy link
Member Author

lintool commented Apr 7, 2024

This is ready to be reviewed. Yes, it's a massive change since we've removed all the target/appassembler/bin launch scripts...

@lintool lintool merged commit e9f4a38 into master Apr 8, 2024
3 checks passed
@lintool lintool deleted the deprecations branch April 8, 2024 14:24
lintool added a commit that referenced this pull request Apr 14, 2024
Changes due to #2444: Remove appassembler-maven-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants