-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extrusion not working #26
Comments
Analysis: Testing your model with latest view3dscene reports errors that you have a self-intersecting polygon:
Since in the test file, you only have one geometry node ( I created a series of images that visualize how the triangulation process "sees" your polygon and how it fails to triangulate it: download the files from https://drive.google.com/open?id=1U-hztHZg12eEOnxfs4nK4lPC-A1DA96F (in triangulation/ subdirectory). Here's an older video showing how the algorithm works correctly on other polygons: https://www.youtube.com/watch?v=XMh608TZRXA . What happened: X3D doesn't allow polygons to be self-intersecting (even when convex=false). View3dscene uses an "ear clipping" triangulation that indeed relies on this fact. IOW, "self-intersecting" polygon may fail the triangulation. "Self-intersecting" means that an edge of the polygon crosses another edge. This happens in your polygon when you try to make a hole:
This makes edges intersect when the polygon closes. It's unavoidable, even if there would be no precision errors. If you draw it using a pencil on a paper, you will have to cross your own line at some point too :), to close the shape. In a summary, I'm afraid this is a problem of your model. It has "self-intersecting" polygon, which is not allowed by X3D. Some X3D browsers may work anyway, but our triangulation will not. Solutions:
|
Great technique to visualize triangulation. I tried to use VLC to create movie, could render but had trouble saving. Switched to Camtasia 9, visualization movie available in SavageTheses archive. Am interested in following up to add a limited form of this kind of functionality to X3DJSAIL and X3D-Edit at some point to diagnose self-intersecting polygons as part of X3D Quality Assurance (QA). |
@brutzman I used ffmpeg on the command-line in the past to combine a series of images into a movie. It should look like this::
The |
Hi everyone,
I'm doing a comparision between different X3D players for my master thesis with Dr. Brutzman at the Naval Postgraduate School. I created a scene showing the Olympic Rings using extrusions. Your player gave me the hint, that something with my extrusion was wrong. I fixed the model and there are no more errors in the console. Octaga and Instant Reality are displaying it perfectly.
Could you help me to find out, whether it is an issue with my model or with the player?
You can find the model on gitlab.nps.edu:
https://gitlab.nps.edu/Savage/mv3204x3dforwebauthors/-/blob/master/assignments/DirectedStudy/Tobias/Scenes/OlympicRings.x3d
Thank you very much for your help.
The text was updated successfully, but these errors were encountered: