Remove legacy hack forcing justfile to be handled as Makefiles #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Previously, casey has preferred to outright remove outdated suggestions about |
Both VIM and Neovim ship with native ftdetect rules to detect justfiles and proper syntax highlighting for them. This modline hack is absolete and actually makes these files *less* accessible in modern editors.
Both VIM and Neovim have shipped with native support and for several releases. This obsolete work around just confuses the issue.
alerque
force-pushed
the
remove-vim-hacks
branch
from
ee6b283 to
c8be3e0
Compare
|
I would support that. In fact I started nuking that section, then restored it when I found some mentions of modern editor support above thinking that might be more controversial than the actual cleanup. I just removed it entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both VIM and Neovim ship with native ftdetect rules to detect justfiles
and proper syntax highlighting for them. This modline hack is absolete
and actually makes these files less accessible in modern editors.