-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rocket-authz middleware #93
Comments
Who can help on |
seems @hackerchai wants to work on this. I'm not sure if Rocket supports middleware... |
I will check it these days.@GopherJ |
Can anyone work on this? |
@hsluoyz I have researched for rocket middleware. I will take this task. If anyone can implement it right now it is also welcomed. |
@hsluoyz I think this issue is high priority. I will start to work on this right now. |
@GopherJ @nodece @hackerchai @PsiACE @kingiw any update on this issue? |
@hackerchai OK. I have created the repo here: https://github.com/casbin-rs/rocket-authz. Looking forward to your progress and PRs! This step means a lot to us and should be highly prioritized. |
@hsluoyz Now the current job in my hand is making real-world-example using actix casbin middleware. After done that, I will put myself in the rocket middeware. |
Just need to add Enforcer to Rocket State, and get this in Request Guards. |
@simoin can you add a README? |
@hsluoyz Done |
I'm not an expert on either Rust or Rocket. @GopherJ @hackerchai @PsiACE Can you give some comments on: https://github.com/simoin/Rocket_Casbin_Demo ? |
@simoin Thanks for your work. Maybe Fairing is a better method to implement Casbin middleware for Rocket. |
@hackerchai Exactly, you could refer to rocket_contrib::database do |
@simoin can you add this middleware to our official site? |
@hsluoyz it is just a binary, not a middleware library. |
@simoin Can it be regarded as an example project to show how to integrate Casbin-RS into Rocket? |
I've rewrote the proj with Fairing. |
OK. Can you add this to our official site? |
@hsluoyz I've sent a PR to casbin-website. |
@simoin thanks! Merged: casbin/casbin-website#122 |
Rocket is one of the top web frameworks in Rust. We already made a Actix middleware (#92) but haven't got a Rocket one.
I think this demo (https://github.com/oiatz/Rocket_Casbin_Demo) is not enough. We will need a full-fledged rocket-authz middleware here: https://github.com/casbin-rs/rocket-authz
The Rocket community has urgent need for good authorization:
The text was updated successfully, but these errors were encountered: