Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example to Actix web examples repo #63

Closed
hsluoyz opened this issue Mar 1, 2020 · 13 comments
Closed

Add an example to Actix web examples repo #63

hsluoyz opened this issue Mar 1, 2020 · 13 comments

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Mar 1, 2020

We should add a Casbin example to: https://github.com/actix/examples

And list Casbin into their README.

@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 1, 2020

@GopherJ @PsiACE

@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 1, 2020

Someone on actix-web's Gitter is requesting this feature: https://gitter.im/actix/actix-web

image

@PsiACE
Copy link
Contributor

PsiACE commented Mar 1, 2020

@hsluoyz

Please check https://github.com/PsiACE/actix-casbin-example first.
If everything is OK, we can add it to actix-example or elsewhere.

@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 1, 2020

@GopherJ

@GopherJ
Copy link
Member

GopherJ commented Mar 1, 2020

@PsiACE Looks good to me, we can add different examples to show different features. Now we just start from: https://github.com/PsiACE/actix-casbin-example

Thanks for it.

@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 2, 2020

Please make PR to: https://github.com/actix/examples

@PsiACE
Copy link
Contributor

PsiACE commented Mar 2, 2020

See actix/examples#264, I just opened this pr.

@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 2, 2020

Good. Thanks.

Also a update from customer: https://gitter.im/actix/actix-web

@PsiACE
Copy link
Contributor

PsiACE commented Mar 2, 2020

He need an example of ACL model. I will update later.

@GopherJ
Copy link
Member

GopherJ commented Mar 2, 2020

@PsiACE Thanks!

@PsiACE
Copy link
Contributor

PsiACE commented Mar 2, 2020

@GopherJ

Please check https://github.com/PsiACE/casbin-examples/tree/actix_fileadapter_acl/actix_fileadapter_acl

I think this can be used as a simple example.

@PsiACE
Copy link
Contributor

PsiACE commented Mar 3, 2020

See actix/examples#264, I just opened this pr.

Done!

@GopherJ GopherJ closed this as completed Mar 6, 2020
@hsluoyz
Copy link
Member Author

hsluoyz commented Mar 7, 2020

Don't forget advertising it next time !

Like I did: actix/examples#267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants