Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservoir area simulation #3

Open
casadoj opened this issue Apr 30, 2024 · 1 comment
Open

Reservoir area simulation #3

casadoj opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@casadoj
Copy link
Owner

casadoj commented Apr 30, 2024

Add to the class Reservoir a method that estimates reservoir surface area from storage as used in Shrestha et al. (2024).

The interest would be to compare the results against observations from satellite imagery. Reservoir area is also important to better estimate gains and losses caused by direct precipitation and evaporation, respectively.

To estimate reservoir area from the simulated volume we can approximate the reservoir shape to a triangular pyramid (Liebe 2005) as done by Shrestha (2024), Sadki (2023), Shin (2019). Under this assumption, there is a shape coefficient $\alpha$ that represents at the same time a relation between the current reservoir area and its maximum area, and the current reservoir storage and its total capacity:

$$\alpha = \left( \frac{a}{Area} \right) ^{1/2} = \left( \frac{v}{Capacity} \right)^{1/3}$$

where $a$ is the estimated reservoir area and $v$ the modelled reservoir storage. From that equation we can estimate the current water area $a$ (the only unknown):

$$a = Area \cdot \alpha^2 = Area \cdot \left( \frac{v}{Capacity} \right)^{2/3}$$

Therefore, we need three attributes that can be extracted from GRanD:

  • Reservoir area (AREA_SKM)
  • Reservoir capacity (CAP_MCM)
@casadoj casadoj changed the title Do we want to put out reservoir are in LISFLOOD? Do we want to put out reservoir area in LISFLOOD? May 2, 2024
@casadoj casadoj added the enhancement New feature or request label Aug 2, 2024
@casadoj casadoj changed the title Do we want to put out reservoir area in LISFLOOD? Reservoir area simulation Aug 2, 2024
@casadoj
Copy link
Owner Author

casadoj commented Aug 2, 2024

I've created the method estimate_area() in Basemodel.

Another option would have been to add another attribute to Basemodel ("Atot" for the maximum reservoir area) and include the estimation in either timestep() or simulate() methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant