Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support bcrypt cryptography #106

Open
dben opened this issue Mar 16, 2020 · 7 comments
Open

Please support bcrypt cryptography #106

dben opened this issue Mar 16, 2020 · 7 comments
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution

Comments

@dben
Copy link

dben commented Mar 16, 2020

Hello,
I would appreciate it if YTT could support bcrypt in the same way as it does SHA256. Maybe using something like https://godoc.org/golang.org/x/crypto/bcrypt

Thanks!

@cppforlife
Copy link
Contributor

hey @dben, ytt has a goal to produce configuration deterministically (one example is no access to random data). bcrypt ultimately needs a salt (in addition to password and cost factor) as an input. https://godoc.org/golang.org/x/crypto/bcrypt internally uses crypt/rand to get x number of random bytes. even if we expose bcrypt function that explicitly takes salt argument, one would have to provide it via a data value (similar to password content) or hard code, and of course hard coding of salt would not be great. im curious how are you planning to use bcrypt in your configuration to understand if we can do something about it.

@cppforlife cppforlife added the discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution label Mar 17, 2020
@cppforlife
Copy link
Contributor

closing this for now since bcrypt requires access to randomness unless salt is provided explicitly. at that point you might as well provide bcrypted password. feel free to reopen if more info arises.

@pivotaljohn
Copy link
Contributor

@github-actions github-actions bot added the carvel triage This issue has not yet been triaged for relevance label Jul 20, 2022
@voor
Copy link

voor commented Jul 20, 2022

Providing the salt to make things consistent seems like a doable workaround, since the password would already need to be stored securely and the salt could be generated prior to ytt call

@pivotaljohn pivotaljohn reopened this Jul 21, 2022
@pivotaljohn pivotaljohn removed the carvel triage This issue has not yet been triaged for relevance label Jul 21, 2022
@github-actions github-actions bot added the carvel triage This issue has not yet been triaged for relevance label Jul 21, 2022
@pivotaljohn pivotaljohn removed the carvel triage This issue has not yet been triaged for relevance label Jul 21, 2022
@pivotaljohn
Copy link
Contributor

Re-opened because we're seriously entertaining this. Exploring the viability of the "workaround" suggested, here.

@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 26, 2022
@benjaminapetersen
Copy link

Another +1 on this!

@ArjonBu
Copy link

ArjonBu commented Nov 2, 2022

Any update to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution
Projects
Status: To Triage
Development

No branches or pull requests

6 participants