Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kctrl: Adding comments to the generated package-build and package-resources.yml. #932

Closed
Tracked by #837
rohitagg2020 opened this issue Oct 12, 2022 · 5 comments
Closed
Tracked by #837

kctrl: Adding comments to the generated package-build and package-resources.yml. #932

rohitagg2020 opened this issue Oct 12, 2022 · 5 comments
Labels
carvel-triage This issue has not yet been reviewed for validity cli Issue for kapp-controller cli stale This issue has had no activity for a while and will be closed soon

Comments

@rohitagg2020
Copy link
Contributor

rohitagg2020 commented Oct 12, 2022 •
edited
Loading

Adding comments to the generated package-build and package-resources.yml.

This will make end user understand better the purpose of each file and section in them
@rohitagg2020 rohitagg2020 mentioned this issue Oct 12, 2022
Closed
17 tasks
@carvel-bot carvel-bot moved this to To Triage in Carvel Oct 12, 2022
@rohitagg2020 rohitagg2020 changed the title Worth exploring adding comments to the generated package-build and package-resources.yml. Adding comments to the generated package-build and package-resources.yml. Oct 12, 2022
@rohitagg2020 rohitagg2020 changed the title Adding comments to the generated package-build and package-resources.yml. kctrl: Adding comments to the generated package-build and package-resources.yml. Oct 12, 2022
@ThomasVitale
Copy link
Contributor

This might be a duplicate of #959

@100mik
Copy link
Contributor

100mik commented Dec 2, 2022

Looks like it, maybe we should keep the newer one.
We should update the existing one with the information that we should also ensure that comments added by user are not overwritten.

@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@100mik
Copy link
Contributor

100mik commented Apr 6, 2023

Clarification: the intention of this issue was to actually add comments to the boilerplate that we generate. We are still unsure about when we will get around to this.
Adding this back to triage.

@100mik 100mik added carvel-triage This issue has not yet been reviewed for validity cli Issue for kapp-controller cli labels Apr 6, 2023
@github-actions
Copy link

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label May 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel May 23, 2023
@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel May 23, 2023
@rohitagg2020
Copy link
Contributor Author

Duplicate issue: #959

@ThomasVitale ThomasVitale mentioned this issue Apr 14, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel-triage This issue has not yet been reviewed for validity cli Issue for kapp-controller cli stale This issue has had no activity for a while and will be closed soon
Projects
Carvel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomasVitale @100mik @rohitagg2020