Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for file exclusions based on entries in an .imgpkgignore file - similar to .gitignore #423

Open
trisberg opened this issue Aug 11, 2022 · 1 comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor Hacktoberfest Issues that are ready for Hacktoberfest participants. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@trisberg
Copy link

Describe the problem/challenge you have
[A description of the current challenge that you are experiencing.]

I'm creating an image for the contents of a git repo, would like to exclude some files/directories when the image is generated - I can try to use --file-exclusion but it would be convenient to have something like a .imgpkgignore file, similar to .gitignore or .tiltignore

Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX (ex: new CLI argument name, the behavior expected).]

it would be convenient to have something like a .imgpkgignore file, similar to .gitignore or .tiltignore where I could specify these file exclusions

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.

@trisberg trisberg added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Aug 11, 2022
@carvel-bot carvel-bot moved this to To Triage in Carvel Aug 11, 2022
@joaopapereira
Copy link
Member

Hey, @trisberg
This does make sense and definitely a cool feature.

In terms of syntax, I agree we should go with the common format that currently is used by gitignore.

Some implementation ideas:

  • When reading the file we can generate the rules and use the same mechanism we have for --file-exclusion
  • Having multiple .imgpkgignore can be allowed. Same behavior as git, the .imgpkgignore will be local to the folder provided
  • We should fail if .imgpkgignore is ignoring the .imgpkg folder

@joaopapereira joaopapereira added good first issue An issue that will be a good candidate for a new contributor carvel accepted This issue should be considered for future work and that the triage process has been completed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed carvel triage This issue has not yet been reviewed for validity labels Aug 24, 2022
@joaopapereira joaopapereira moved this from To Triage to Unprioritized in Carvel Aug 24, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@joaopapereira joaopapereira moved this from To Triage to Unprioritized in Carvel Feb 14, 2023
@joaopapereira joaopapereira added the Hacktoberfest Issues that are ready for Hacktoberfest participants. label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor Hacktoberfest Issues that are ready for Hacktoberfest participants. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Unprioritized
Development

No branches or pull requests

2 participants